Skip to content

Follows Astral's recommended pattern for installing uv in Docker by copying the statically-compiled binary directly from the official image rather than installing via pip.#2880

Merged
jmthomas merged 7 commits into
mainfrom
2863-follows-astrals-own-recommended-pattern-for-installing-uv
Mar 5, 2026
Merged

Conversation

@mcosgriff
Copy link
Copy Markdown
Contributor

@mcosgriff mcosgriff commented Feb 25, 2026

Changes

  • openc3-ruby/Dockerfile:
    Combine separate RUN commands (sed/cp for .gemrc, addgroup/adduser) to reduce image layers
  • scripts/linux/openc3_build_ubi.sh: Accept arbitrary --build-arg and other docker build flags as pass-through arguments; add --help, selective image building, build time summary report, and registry login handling
  • .github/workflows/python_unit_tests.yml: Pin uv version to 0.10.4, use setup-uv to handle Python installation (removes separate step), add uv cache prune --ci post-step
  • .github/dependabot.yml: Add uv ecosystem entry to keep uv.lock dependencies updated automatically
  • openc3/python/openc3/script/suite_runner.py: Replace generic Exception with AttributeError in three missing-method raises (SonarQube S112)
  • openc3/python/test/script/test_suite_runner.py: Add tests covering the AttributeError paths for missing script, setup, and teardown methods
  • openc3/python/test/api/test_cmd_api.py: Fix bad from packets.packet import Packet import (should be openc3.packets.packet); add missing cmd_no_range_check, cmd_raw, cmd_no_checks, cmd_raw_no_range_check, cmd_raw_no_hazardous_check, cmd_raw_no_checks imports that were omitted when the file was converted from wildcard imports
  • openc3/python/pyproject.toml: Fix filterwarnings for valkey/redis get_connection DeprecationWarning — the warning's stacklevel=5 causes pytest to attribute it to our code rather than the upstream library, so the module qualifier is dropped from the filter

Notes

  • uv binary version should be bumped intentionally; dependabot will handle Python package dependency updates via uv.lock but not the binary version itself

@mcosgriff mcosgriff linked an issue Feb 25, 2026 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.26%. Comparing base (c629a3b) to head (b79cd42).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
+ Coverage   78.24%   78.26%   +0.02%     
==========================================
  Files         673      673              
  Lines       55204    55204              
  Branches      728      728              
==========================================
+ Hits        43196    43208      +12     
+ Misses      11930    11918      -12     
  Partials       78       78              
Flag Coverage Δ
python 79.42% <ø> (+0.09%) ⬆️
ruby-api 79.52% <ø> (-0.17%) ⬇️
ruby-backend 82.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread openc3-ruby/Dockerfile Outdated
Comment thread openc3-ruby/Dockerfile Outdated
* Removed redis warnings in unit tests
* Combined a couple RUN commands together in UBI Dockerfile
* Raising AttributeError instead of Exception in suite_runner.py to try and be a bit more precise on the exception, added a few unit tests for this case.
@mcosgriff mcosgriff marked this pull request as ready for review February 27, 2026 17:30
Comment thread openc3/python/openc3/api/cmd_api.py Outdated
Comment thread openc3/python/test/api/test_cmd_api.py Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2026

Comment thread .github/dependabot.yml
Comment thread openc3/python/pyproject.toml
@mcosgriff mcosgriff requested a review from ryanmelt March 4, 2026 19:46
@jmthomas jmthomas merged commit 130f90a into main Mar 5, 2026
32 of 34 checks passed
@jmthomas jmthomas deleted the 2863-follows-astrals-own-recommended-pattern-for-installing-uv branch March 5, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follows Astral's own recommended pattern for installing uv

3 participants