Skip to content

Add validate and timeout info to queued commands#2893

Merged
jmthomas merged 2 commits into
mainfrom
queue_validate
Mar 2, 2026
Merged

Add validate and timeout info to queued commands#2893
jmthomas merged 2 commits into
mainfrom
queue_validate

Conversation

@jmthomas
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.30%. Comparing base (19e909e) to head (393d900).

Files with missing lines Patch % Lines
...s-cmd-tlm-api/app/controllers/queues_controller.rb 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2893      +/-   ##
==========================================
+ Coverage   78.29%   78.30%   +0.01%     
==========================================
  Files         673      673              
  Lines       55118    55130      +12     
  Branches      728      728              
==========================================
+ Hits        43157    43172      +15     
+ Misses      11883    11880       -3     
  Partials       78       78              
Flag Coverage Δ
python 79.34% <ø> (+<0.01%) ⬆️
ruby-api 80.31% <75.00%> (+0.06%) ⬆️
ruby-backend 82.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Copy Markdown
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because of running cmd() and then cmd_no_validation() back-to-back, but on a non validated command in the queue, in the command history shows the command twice

Image Image

@jmthomas
Copy link
Copy Markdown
Member Author

I think this is because of running cmd() and then cmd_no_validation() back-to-back, but on a non validated command in the queue, in the command history shows the command twice

Actually the validate option is a keyword so it shouldn't show up twice. However, the check for hazardous actually does does send it and then rescues it before sending again with cmd_no_hazardous_check. This in only if you do exec_command I think.

Did you release the queue or manually click the Play (exec) button?

@jmthomas
Copy link
Copy Markdown
Member Author

jmthomas commented Mar 2, 2026

Duplicate messages fixed in #2900

@jmthomas jmthomas requested a review from clayandgen March 2, 2026 16:53
@jmthomas jmthomas merged commit 0ce3c12 into main Mar 2, 2026
30 of 33 checks passed
@jmthomas jmthomas deleted the queue_validate branch March 2, 2026 20:48
jmthomas added a commit that referenced this pull request Mar 21, 2026
Add validate and timeout info to queued commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants