Skip to content

Add migration to remove store_id from plugin#2928

Merged
jmthomas merged 2 commits into
mainfrom
bug/store-id
Mar 5, 2026
Merged

Add migration to remove store_id from plugin#2928
jmthomas merged 2 commits into
mainfrom
bug/store-id

Conversation

@ryan-pratt
Copy link
Copy Markdown
Contributor

Runs in init container. This should've been part of #2858

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.50%. Comparing base (f9d0650) to head (32bed1b).
⚠️ Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2928      +/-   ##
==========================================
+ Coverage   78.28%   78.50%   +0.21%     
==========================================
  Files         673      673              
  Lines       55204    55275      +71     
  Branches      728      728              
==========================================
+ Hits        43216    43392     +176     
+ Misses      11910    11805     -105     
  Partials       78       78              
Flag Coverage Δ
python 79.75% <ø> (+0.42%) ⬆️
ruby-api 80.90% <ø> (+0.79%) ⬆️
ruby-backend 82.14% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to be incorporated into the existing 20260204000000_remove_decom_reducer.rb because that is reinstalling all the PluginModels which will fail because this hasn't run yet.

@ryanmelt do you agree?

@ryanmelt
Copy link
Copy Markdown
Member

ryanmelt commented Mar 5, 2026

Or you could change dates on the migration files to put this first

@jmthomas jmthomas merged commit 358450b into main Mar 5, 2026
22 of 23 checks passed
@jmthomas jmthomas deleted the bug/store-id branch March 5, 2026 02:03
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2026

jmthomas added a commit that referenced this pull request Mar 21, 2026
Add migration to remove store_id from plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants