Add sslHeaders and remove OPENC3_ALLOW_HTTP to ssl and letsencrypt#2929
Conversation
| headers: | ||
| customRequestHeaders: | ||
| X-Forwarded-Proto: "https" | ||
| X-Forwarded-Port: "443" |
There was a problem hiding this comment.
This was already part of the enterprise traefik configs so I assume it's needed here as well
There was a problem hiding this comment.
This won't hurt anything, but this was for Keycloak which doesn't exist in Core
| headers: | ||
| contentSecurityPolicy: >- | ||
| {{ if env "OPENC3_ALLOW_HTTP" }}default-src 'self' blob: data: http: https:; script-src 'unsafe-inline' 'unsafe-eval' http: https: blob:; connect-src blob: http: https: wss: ws:; style-src 'unsafe-inline' http: https:; object-src 'none';{{ else }}default-src 'self' blob: data: https: http://localhost:* http://host.docker.internal:* http://*.local:*; script-src 'unsafe-inline' 'unsafe-eval' https: blob: http://localhost:* http://host.docker.internal:* http://*.local:*; connect-src blob: https: wss: http://localhost:* http://host.docker.internal:* http://*.local:* ws://localhost:* ws://host.docker.internal:* ws://*.local:*; style-src 'unsafe-inline' https: http://localhost:* http://host.docker.internal:* http://*.local:*; object-src 'none';{{ end }} | ||
| default-src 'self' blob: data: https: http://localhost:* http://host.docker.internal:* http://*.local:*; script-src 'unsafe-inline' 'unsafe-eval' https: blob: http://localhost:* http://host.docker.internal:* http://*.local:*; connect-src blob: https: wss: http://localhost:* http://host.docker.internal:* http://*.local:* ws://localhost:* ws://host.docker.internal:* ws://*.local:*; style-src 'unsafe-inline' https: http://localhost:* http://host.docker.internal:* http://*.local:*; object-src 'none'; |
There was a problem hiding this comment.
Doesn't make sense to allow HTTP when you're doing encryption which is the whole point of this traefik config
|
| headers: | ||
| customRequestHeaders: | ||
| X-Forwarded-Proto: "https" | ||
| X-Forwarded-Port: "443" |
There was a problem hiding this comment.
This won't hurt anything, but this was for Keycloak which doesn't exist in Core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
+ Coverage 78.21% 78.27% +0.05%
==========================================
Files 673 673
Lines 55204 55204
Branches 728 728
==========================================
+ Hits 43180 43213 +33
+ Misses 11946 11913 -33
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
No description provided.