Fix latest autocomplete#2941
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 77.79% 78.52% +0.72%
==========================================
Files 471 673 +202
Lines 34647 55277 +20630
Branches 728 728
==========================================
+ Hits 26955 43406 +16451
- Misses 7614 11793 +4179
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmthomas
reviewed
Mar 5, 2026
| OPENC3_TOOLS_BUCKET: "${OPENC3_TOOLS_BUCKET}" | ||
| OPENC3_BUCKET_URL: "${OPENC3_BUCKET_URL}" | ||
| OPENC3_ALLOW_HTTP: "${OPENC3_ALLOW_HTTP}" | ||
| OPENC3_ALLOW_HTTP: "${OPENC3_ALLOW_HTTP:-}" |
Member
There was a problem hiding this comment.
This got me thinking ... does simply having this here make this "set" even if OPENC3_ALLOW_HTTP is not defined?
Member
There was a problem hiding this comment.
No I confirmed it is working as expected
jmthomas
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix warning with OPENC3_ALLOW_HTTP