Skip to content

Added polyfill-8.3/8.4 in Composer #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Added polyfill-8.3/8.4 in Composer #4268

merged 7 commits into from
Oct 14, 2024

Conversation

addison74
Copy link
Contributor

I have added polyfill-8.3 in the composer file.

@github-actions github-actions bot added the composer Relates to composer.json label Oct 11, 2024
@sreichel
Copy link
Contributor

sreichel commented Oct 12, 2024

We don't use these methods in core, but why not.

Please use composer update --lock command and add updated composer.lock too.

@addison74 addison74 marked this pull request as draft October 12, 2024 07:03
@sreichel
Copy link
Contributor

sreichel commented Oct 13, 2024

@colinmollenhour tech question. How it is possible to create new branches here? (https://github.com/OpenMage/magento-lts/branches/all)

I thought we disabled it times ago?

@sreichel sreichel changed the title polyfill-8.3 in Composer Added polyfill-8.3/8.4 in Composer Oct 13, 2024
Copy link
Contributor

github-actions bot commented Oct 13, 2024

Test Results

252 tests  ±0   252 ✅ ±0   2s ⏱️ ±0s
 72 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0d58ade. ± Comparison against base commit bc8dd05.

♻️ This comment has been updated with latest results.

@sreichel sreichel marked this pull request as ready for review October 13, 2024 04:30
sreichel
sreichel previously approved these changes Oct 13, 2024
@github-actions github-actions bot removed the phpstan label Oct 13, 2024
kiatng
kiatng previously approved these changes Oct 14, 2024
@sreichel sreichel dismissed stale reviews from kiatng and themself via 22ab01a October 14, 2024 03:06
@sreichel sreichel requested a review from kiatng October 14, 2024 03:09
@kiatng kiatng merged commit f96b282 into main Oct 14, 2024
31 checks passed
@sreichel sreichel deleted the ADDISON74-polifyll-8.3 branch October 14, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer Relates to composer.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants