-
Notifications
You must be signed in to change notification settings - Fork 75
EDHOC Object definition. #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prod
Are you sure you want to change the base?
Conversation
Signed-off-by: David Navarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs proper license for OMA
Signed-off-by: David Navarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to email address.
Update email address
Update email address
Hi David, First off, thanks for putting together the EDHOC object definition. It’s a solid proposal and, in my opinion, definitely something that should be added to LwM2M. As I was going through it, a few questions and potential improvements came to my mind. I’ve listed them below, hope you find them useful. Happy to discuss further if anything’s unclear :)
Looking forward to your thoughts! |
<RangeEnumeration></RangeEnumeration> | ||
<Units></Units> | ||
<Description><![CDATA[Stores the LwM2M Client's private key. | ||
If this Resource is null or not instantiated, the LwM2M Client is to use OOB credentials (e.g. by using EST), and the Client Public Key Resource must be null or not instantiated.]]></Description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saying that the "resource is null" is vague: What does the private key need to contain? Does it mean that an internal pointer in the implementation points to NULL? Or does it mean it contains a single, null byte? ?
<Resources> | ||
<Item ID="0"> | ||
<Name>Peer Public Key Identifier</Name> | ||
<Operations></Operations> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why none of these resources carry an operation? Without an operation, the information is essentially hidden on the device; it can't be retrieved, written or executed using standard writes, reads or executes.
Maybe I don't understand the purpose of the object fully, but what is the reason to specify an object if none of the information is accessible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it results from restriction that this object should be accessed only by LwM2M Bootstrap Server. The same lack of Operations
approach is used for LwM2M Security, LwM2M OSCORE and LwM2M COSE objects:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it results from restriction that this object should be accessed only by LwM2M Bootstrap Server. The same lack of
Operations
approach is used for LwM2M Security, LwM2M OSCORE and LwM2M COSE objects:)
That was my assumption also, hence I asked for clarification. But for example Public Keys technically could be readable...
@dnav Please have a look at the comments submitted. I would like to resolved on 6/24 if possible |
In making a submission to the Open Mobile Alliance Registry, you understand and agree that your submission is made under the BSD-3 Clause License as set forth on the Open Mobile Alliance Registry and that additional formats of your submission may be created by the Open Mobile Alliance tools and processes, which may convert the content of your submission, and that the Open Mobile Alliance bears no liability for the additional formats of your submission nor for any conversion of the content of your submission.