fix(sdk): preserve release branch refs during install#33
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SDK install flow so branch installs keep the full Git ref (e.g. release/<x>) for cloning while still using a clean folder name (without release/) for the install directory.
Changes:
- Added install request payload types (
SdkInstallVersionPayload,SdkInstallRequestData) and expanded SDK state to trackavailableReleases/availableBranches. - Updated the webview install request to send both a display/folder
nameand agitReffor branches, preservingrelease/*during clone. - Updated the extension-side installer to consume
gitRef(with legacy normalization fallback) and keep folder naming consistent.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| webview-vue/src/types/index.ts | Adds install payload types and enriches SDK version/state types (chips + release/branch lists). |
| webview-vue/src/composables/useSdkManager.ts | Builds the new install payload (including gitRef) and centralizes branch folder-name normalization. |
| webview-vue/src/components/sdk/InstallPathSelector.vue | Aligns the install path suffix preview with the same branch folder-name normalization logic. |
| src/providers/vueWebviewProvider.ts | Handles new payload shape, preserves branch refs for cloning, and normalizes legacy branch refs when needed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+171
to
+179
| if (!state.value.selectedBranch) { | ||
| throw new Error('未找到选择的分支信息'); | ||
| } | ||
|
|
||
| const gitRef = state.value.selectedBranch === 'latest' ? 'main' : state.value.selectedBranch; | ||
| versionPayload = { | ||
| name: getBranchFolderName(gitRef), | ||
| gitRef, | ||
| type: 'branch', |
Comment on lines
+11
to
+19
| const RELEASE_BRANCH_PREFIX = 'release/'; | ||
|
|
||
| function getBranchFolderName(branchRef: string): string { | ||
| const normalizedBranchRef = branchRef === 'latest' ? 'main' : branchRef; | ||
|
|
||
| return normalizedBranchRef.startsWith(RELEASE_BRANCH_PREFIX) | ||
| ? normalizedBranchRef.slice(RELEASE_BRANCH_PREFIX.length) | ||
| : normalizedBranchRef; | ||
| } |
Comment on lines
+62
to
+70
| const RELEASE_BRANCH_PREFIX = 'release/'; | ||
|
|
||
| function getBranchFolderName(branchRef: string): string { | ||
| const normalizedBranchRef = branchRef === 'latest' ? 'main' : branchRef; | ||
|
|
||
| return normalizedBranchRef.startsWith(RELEASE_BRANCH_PREFIX) | ||
| ? normalizedBranchRef.slice(RELEASE_BRANCH_PREFIX.length) | ||
| : normalizedBranchRef; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.