Fix ECDSA signature malleability#3610
Merged
Merged
Conversation
frangio
added a commit
that referenced
this pull request
Aug 10, 2022
(cherry picked from commit d693d89)
|
For reference, this pull request is motivated by this security advisory - GHSA-4h98-2769-gh6h |
This was referenced Jan 9, 2023
davidbrai
added a commit
to nounsDAO/nouns-monorepo
that referenced
this pull request
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a kind of signature malleability that is present in the
ECDSA.recoverandtryRecovervariants that take abytes signatureargument, which can be both 65 bytes long and the compact 64 bytes encoded version.