Update tutorial to use dynamic state for viewport and scissor #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more need to recreate the graphics pipeline as viewport and scissor state are now dynamic
This is not needed anymore
…d function chapter
… chain recreation chapter Removed render pass destruction/creation for swap chain recreation, no longer necessary
|
I'll review this sometime this week. |
Overv
reviewed
Jun 20, 2022
en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/02_Fixed_functions.md
Outdated
Show resolved
Hide resolved
en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/02_Fixed_functions.md
Outdated
Show resolved
Hide resolved
en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/02_Fixed_functions.md
Outdated
Show resolved
Hide resolved
en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/02_Fixed_functions.md
Outdated
Show resolved
Hide resolved
en/03_Drawing_a_triangle/02_Graphics_pipeline_basics/02_Fixed_functions.md
Outdated
Show resolved
Hide resolved
Incorporate suggestions Co-authored-by: Alexander Overvoorde <[email protected]>
|
If you replace the link and (re)move the early command buffer mentions then I'll approve and merge 👍 |
|
I have pushed the changes. |
Overv
added a commit
that referenced
this pull request
Mar 8, 2023
* Prefer use of dynamic state for viewport and scissor * Slight rewording, working in-page anchor * Updated command buffers chapter and code to use dynamic viewport and scissor state * Updated swap chain recreation chapter No more need to recreate the graphics pipeline as viewport and scissor state are now dynamic * Updated command buffer chapter code to use dynamic viewport and scissor * Removed render pass destruction/creation for swap chain recreation This is not needed anymore * Use dynamic state for viewport and scissor for samples after the fixed function chapter * Use dynamic state for viewport and scissor for samples after the swap chain recreation chapter Removed render pass destruction/creation for swap chain recreation, no longer necessary * Removed duplicate code * Wording change * Changed wording on chapter intro, moved dynamic state paragraph to the top * Fixed wording * Fixed wording * C++ style cast * Wording * Wording * Wording * Added note on renderpass recreation * Apply suggestions from code review Incorporate suggestions Co-authored-by: Alexander Overvoorde <[email protected]> * Added dynamic state to conclusion chapter * Remove unnecessary link * Remove code referencing command buffers too early Co-authored-by: Alexander Overvoorde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tutorial to use dynamic state for viewport and scissor rectangles. This simplifies things a lot and no longer requires e.g. pipelines and render passes to be recreated with the swap chain on window resize.