Removing Columns/Rows Containing Merged Cells #4465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHPOffice#282, which went stale over 7 years ago, and is now reopened. This is certainly related to issue PHPOffice#4379. If merged cells are in the midst of deleted rows/columns, the merge may continue to exist after the deletion, leading to various problems including spreadsheet corruption. The problem is not with either Reader or Writer. This PR will automatically unmerge all merged cells whose first cell is in the delete range before performing the deletion. This will address the corruption problem. Something more sophisticated may be required, so I won't merge this PR for a while to give me a chance to think about it some more.
When the merged cells start outside the deleted range but end inside it, the merge is truncated to that portion which is outside the range.
This was referenced May 15, 2025
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
May 16, 2025
11 tasks
oleibman
added a commit
that referenced
this pull request
May 16, 2025
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
May 16, 2025
11 tasks
oleibman
added a commit
that referenced
this pull request
May 16, 2025
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
May 16, 2025
11 tasks
oleibman
added a commit
that referenced
this pull request
May 16, 2025
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
May 16, 2025
11 tasks
oleibman
added a commit
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #282, which went stale over 7 years ago, and is now reopened. This is certainly related to issue #4379. If merged cells are in the midst of deleted rows/columns, the merge may continue to exist after the deletion, leading to various problems including spreadsheet corruption. The problem is not with either Reader or Writer.
This PR will automatically unmerge all merged cells whose first cell is in the delete range before performing the deletion. This will address the corruption problem. Something more sophisticated may be required, so I won't merge this PR for a while to give me a chance to think about it some more.
This is:
Checklist: