Skip to content

VSCode PowerShell Integrated Console hangs when running PSReadLine 2.2.0-beta3 #1518

Closed
@alialo

Description

@alialo

VSCode PowerShell extension release v2020.4.1-preview or newer causes the integrated console to hang when attempting to run code if PSReadLine 2.2.0-beta3 is installed. The only changes introduced in v2020.4.1-preview are related to PowerShellEditorServices so I've raised the issue here and closed the existing one (can be found here for reference).

It appears to be related to pull 1255. Removing PSReadLine 2.2.0-beta3 and reverting back to beta2 fixes the problem, as does rolling back the extension to v2020.4.0-preview or older.

Activity

ghost added
Needs: TriageMaintainer attention needed!
on Jul 3, 2021
andyleejordan

andyleejordan commented on Jul 6, 2021

@andyleejordan
Member

Wow, thanks for the investigation! That's super interesting because we just recently traced an issue in PSReadLine 2.2.0-beta3 itself that caused more problems: PowerShell/PSReadLine#2616 I'm wondering how this interaction played out.

brwilkinson

brwilkinson commented on Jul 12, 2021

@brwilkinson

subscribe.

andyleejordan

andyleejordan commented on Jul 12, 2021

@andyleejordan
Member

So I think the way this played out is that in the rework in #1255, PSES started using a linked cancellation token in PSReadLine to run correctly and asynchronously, but in beta3 of PSReadLine, the cancellation token was erroneously being dropped for an unlinked default token, which has now been fixed in PowerShell/PSReadLine#2636.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @alialo@andyleejordan@brwilkinson

        Issue actions

          VSCode PowerShell Integrated Console hangs when running PSReadLine 2.2.0-beta3 · Issue #1518 · PowerShell/PowerShellEditorServices