[Feature] Workspace Setting for Integrated Console PS Version

[JustinGrote]

Summary of the new feature

I work different projects, some require WinPS5 due to library dependencies, some use PS6+. Currently the integrated terminal that is used appears to be a "global" setting. If I switch it to PS6+ in one project and then open the other, it stays PS6+, this leads to annoying toggle back and forth.

I want to be able to set so that when I open a certain project or workspace, it remembers what integrated terminal version I was using for that workspace

Proposed technical implementation details (optional)

User/Workspace setting for powershell.integratedterminalversion that would match the string in the session picker dropdown, e.g. "Powershell", "Windows Powershell (x64)", "Powershell Preview", etc.

[SydneyhSmith]

Thanks for opening this feature request @JustinGrote! I was looking through other issues and was wondering if you feel that #190 addresses the same concerns as you?

[JustinGrote]

That issue is from a really long time ago before multi-root workspaces were a native thing in VSCode, so I'd say not exactly, it just needs to be a setting to change which version of powershell the integrated console starts with, and it needs to be respected both as a user setting and a workspace setting.

…

On Tue, Jul 23, 2019 at 2:29 PM Sydney Smith ***@***.***> wrote: Thanks for opening this feature request @JustinGrote <https://github.com/JustinGrote>! I was looking through other issues and was wondering if you feel that #190 <#190> addresses the same concerns as you? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2099?email_source=notifications&email_token=ADUNKURGHZVUY3E3YPIU4DTQA5Z4NA5CNFSM4IGGZ532YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2UPYNY#issuecomment-514391095>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADUNKUWRTBPGKYMMKMHLDODQA5Z4NANCNFSM4IGGZ53Q> .

[TylerLeonhardt]

@JustinGrote is this the kind of setting you're looking for?

https://github.com/PowerShell/vscode-powershell/blob/master/package.json#L574-L576

[JustinGrote]

@TylerLeonhardt my problems are likely related to #1586. I did some more extensive testing and found the following (using powershell-preview extension):

1. powershell.powershellexepath gets populated immediately if you toggle shell from the lower right menu (or use Show Session Menu)
2. It does not update if you specify a powershell.powershelldefaultversion and reload window.
3. Killing the terminal after the reload reverts to this powershell.powershellexepath that was previously saved in (because it was never updated)

For instance if you set powershelldefaultversion to "Powershell Preview" (added via AdditionalExePaths) but your last shell was "Windows Powershell (x64)", then PS Preview will load on reload, but if you kill the terminal via the trash icon and restart it, it comes back as "Windows Powershell (x64)"

Fix
Make it so that when the extension finds the selection via powershell.powershelldefaultversion, it immediately sets the settings.json "placeholder" in the same way that the session selection menu does.

Alternatively, make a kill/reload of the terminal window follow the same discovery process as "first launch" and not just go with whatever powershellexepath is set to.

Side bug
If you set powershellexepath as a workspace setting, it doesn't get updated, so it is "sticky" and even if you toggle to another console it keeps coming back to whatever is set in workspace setting. This kind of meets my criteria, except I can't toggle to another version of powershell quickly without commenting it out if I want to test xplat compatability or something.

That aside, it does seem to work on a workspace-level as long as I don't kill the window, so if the above bug is fixed I think we are good to go and can close this.

EDIT: I can record a screengif of the behavior if you can't repro. Thanks!

[JustinGrote]

Workaround

Add this to your Microsoft.VSCode_profile.ps1

#Todo: Detect Insiders vs. regular vscode
if ($isWindows) {
    $vscodeSettingsPath = "$($env:APPDATA)\Code - Insiders\User\settings.json"
} else {
    $vscodeSettingsPath = "$HOME/.config/Code - Insiders/User/settings.json"
}
$PowershellExePath = (Get-Process -id $pid).path -replace '\\','\\'
$PowershellExePathRegex = '(?<="powershell\.powerShellExePath": ")(.+)(?=")'
$vscodeSettings = gc -raw $vscodeSettingsPath
$vscodeSettings -replace $PowershellExePathRegex,$PowershellExePath | Out-File -Encoding UTF8 $vscodeSettingsPath
Remove-Variable PowershellExePath,PowershellExePathRegex,vscodeSettingsPath,vscodeSettings

This will basically do the behavior I described above, and then whatever you set powershell.powershellDefaultVersion to will be sticky to that project, and stay that way if you terminal and reload a session. You can set a global user setting, as well as a per-workspace override, and it works fine. If you decide to switch session mid-session, will still be fine.

You will get a nag message on startup if it had to switch runtimes that the runtime had switched and ask if you want to restart it, just ignore it.

[JustinGrote]

Recommended Fix

@TylerLeonhardt There should be a call to changePowershellExePath here:

vscode-powershell/src/session.ts

Lines 293 to 295 in 0388343

	if (powerShellDefaultVersion) {
	powerShellExePath = powerShellDefaultVersion.exePath;
	} else {

[SydneyhSmith]

@JustinGrote thanks for providing all this info and proposed work around...we just discussed this and the possible ramification and are worried that this would cause unexpected behavior when choosing a version from the session menu...you are correct though in that we need to make a fix to ensure that the default version specified in the settings is being used for any session not started by the session menu