Skip to content

Fix attach to process debugging #3849

Closed
@andyleejordan

Description

@andyleejordan
Member

This is tied into "remote debugging" and we need to be sure it works.

Activity

ghost added
Needs: TriageMaintainer attention needed!
on Feb 23, 2022
JustinGrote

JustinGrote commented on Feb 24, 2022

@JustinGrote
Collaborator

There is still a big issue, more about runspaces, that entering a runspace still hangs the console. This is a "big deal" showstopper for doing any kind of debugging in this environment.

andyleejordan

andyleejordan commented on Feb 24, 2022

@andyleejordan
MemberAuthor

Completely agree!

andyleejordan

andyleejordan commented on Feb 24, 2022

@andyleejordan
MemberAuthor

It's probably our last and biggest blocker to move the preview to stable.

andyleejordan

andyleejordan commented on Feb 28, 2022

@andyleejordan
MemberAuthor

Just running the "attach process" kinda works? I mean it's broken in a lot of ways too, and I'm not sure how it's supposed to work.

SeeminglyScience

SeeminglyScience commented on Mar 1, 2022

@SeeminglyScience
Collaborator

Attach to process definitely doesn't work.

  1. Doesn't Debug-Runspace after entering the target process
  2. If you do it manually, breakpoints aren't transferred
  3. Trying to abort the debug session dead locks the session completely

Note, unfortunately this is a potentially quite large work item and was the most difficult piece to fix when I integrated PSRL years ago. I have also verified it does work in stable. Pretty finicky, but definitely usable.

Hopefully easier to fix with the improved architecture though 🤞

added
Bug: Pre-releaseBugs reproducing only in the pre-release extension.
and removed on Mar 1, 2022
SeeminglyScience

SeeminglyScience commented on Mar 1, 2022

@SeeminglyScience
Collaborator

We also need to test (after this is fixed) if debugging an azure function still works.

andyleejordan

andyleejordan commented on Mar 3, 2022

@andyleejordan
MemberAuthor

😭 I hope it ends up being easier to fix than we think!

moved this from Todo to In Progress in Sea Biscuiton Mar 3, 2022
changed the title [-]Verify attach to process scenario works[/-] [+]Fix (or disable) "attach to process" debugging[/+] on Mar 15, 2022
andyleejordan

andyleejordan commented on Apr 18, 2022

@andyleejordan
MemberAuthor
Repository owner moved this from In Progress to Done in Sea Biscuiton Apr 18, 2022
JustinGrote

JustinGrote commented on Apr 18, 2022

@JustinGrote
Collaborator

Can confirm this years-long bug is finally fixed in preview. You can debug an Azure Functions worker and get repl at the console at that point.
image

changed the title [-]Fix (or disable) "attach to process" debugging[/-] [+]Fix attach to process" debugging[/+] on Jun 14, 2022
changed the title [-]Fix attach to process" debugging[/-] [+]Fix attach to process debugging[/+] on Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @andyleejordan@JustinGrote@StevenBucher98@SeeminglyScience

      Issue actions

        Fix attach to process debugging · Issue #3849 · PowerShell/vscode-powershell