Skip to content

Remove explicit tabIndex values to comply with accessibility standards #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove explicit tabIndex values to comply with accessibility standards #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94df5e6
Initial plan
Copilot Dec 4, 2025
044aab3
Remove explicit tabIndex attributes to meet accessibility standards
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/components/atoms/__tests__/__snapshots__/fullscreen.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ exports[`Fullscreen renders correctly with props 1`] = `
}
}
onClick={[Function]}
tabIndex="12"
type="button"
>
<svg
Expand Down Expand Up @@ -120,7 +119,6 @@ exports[`Fullscreen renders correctly without props 1`] = `
}
}
onClick={[Function]}
tabIndex="12"
type="button"
>
<svg
Expand Down
2 changes: 0 additions & 2 deletions src/components/atoms/__tests__/__snapshots__/logo.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ exports[`Logo renders correctly with props 1`] = `
>
<a
href="/"
tabIndex="1"
>
EYESBOUND
</a>
Expand Down Expand Up @@ -81,7 +80,6 @@ exports[`Logo renders correctly without props 1`] = `
>
<a
href="/"
tabIndex="1"
>
EYESBOUND
</a>
Expand Down
24 changes: 0 additions & 24 deletions src/components/atoms/__tests__/__snapshots__/navigation.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,63 +82,55 @@ exports[`Navigation renders correctly when menu is toggled 1`] = `
<li>
<a
href="/picture"
tabIndex="2"
>
Overview
</a>
</li>
<li>
<a
href="/series/shuttered"
tabIndex="3"
>
»Shuttered«
</a>
</li>
<li>
<a
href="/category/architecture"
tabIndex="4"
>
Architecture
</a>
</li>
<li>
<a
href="/category/environment"
tabIndex="5"
>
Environment
</a>
</li>
<li>
<a
href="/category/floral"
tabIndex="6"
>
Floral
</a>
</li>
<li>
<a
href="/category/light"
tabIndex="7"
>
Light
</a>
</li>
<li>
<a
href="/worldmap"
tabIndex="8"
>
Worldmap
</a>
</li>
<li>
<a
href="/imprint"
tabIndex="9"
>
Contact
</a>
Expand Down Expand Up @@ -234,63 +226,55 @@ exports[`Navigation renders correctly with props 1`] = `
<li>
<a
href="/picture"
tabIndex="2"
>
Overview
</a>
</li>
<li>
<a
href="/series/shuttered"
tabIndex="3"
>
»Shuttered«
</a>
</li>
<li>
<a
href="/category/architecture"
tabIndex="4"
>
Architecture
</a>
</li>
<li>
<a
href="/category/environment"
tabIndex="5"
>
Environment
</a>
</li>
<li>
<a
href="/category/floral"
tabIndex="6"
>
Floral
</a>
</li>
<li>
<a
href="/category/light"
tabIndex="7"
>
Light
</a>
</li>
<li>
<a
href="/worldmap"
tabIndex="8"
>
Worldmap
</a>
</li>
<li>
<a
href="/imprint"
tabIndex="9"
>
Contact
</a>
Expand Down Expand Up @@ -386,63 +370,55 @@ exports[`Navigation renders correctly without props 1`] = `
<li>
<a
href="/picture"
tabIndex="2"
>
Overview
</a>
</li>
<li>
<a
href="/series/shuttered"
tabIndex="3"
>
»Shuttered«
</a>
</li>
<li>
<a
href="/category/architecture"
tabIndex="4"
>
Architecture
</a>
</li>
<li>
<a
href="/category/environment"
tabIndex="5"
>
Environment
</a>
</li>
<li>
<a
href="/category/floral"
tabIndex="6"
>
Floral
</a>
</li>
<li>
<a
href="/category/light"
tabIndex="7"
>
Light
</a>
</li>
<li>
<a
href="/worldmap"
tabIndex="8"
>
Worldmap
</a>
</li>
<li>
<a
href="/imprint"
tabIndex="9"
>
Contact
</a>
Expand Down
2 changes: 1 addition & 1 deletion src/components/atoms/fullscreen.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function Fullscreen({callback = defaultCallback, selector = ''}) {
<button
aria-label='Toggle fullscreen'
type='button' css={buttonClass} className={classnames({fullScreen})}
tabIndex='12' onClick={() => toggleFullscreen(selector)}
onClick={() => toggleFullscreen(selector)}
>
{fullScreen ? <IconFullscreenExit/> : <IconFullscreen/>}
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/components/atoms/logo.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const logo = css`
const {GATSBY_SITE_NAME = 'EYESBOUND'} = process.env;

function Logo({isFullscreen = false}) {
return <h1 css={logo} className={classnames({isFullscreen})}><a href='/' tabIndex='1'>{GATSBY_SITE_NAME}</a></h1>;
return <h1 css={logo} className={classnames({isFullscreen})}><a href='/'>{GATSBY_SITE_NAME}</a></h1>;
}

Logo.propTypes = {
Expand Down
16 changes: 8 additions & 8 deletions src/components/atoms/navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@ function Navigation({isFullscreen = false}) {
return (
<nav css={navigationStyle} className={classnames({open: menuOpen, isFullscreen})}>
<ul>
<li><a ref={linkOverview} href={`/${PICTURE.path}`} tabIndex='2'>Overview</a></li>
<li><a ref={linkShuttered} href={`/${SERIES.path}/shuttered`} tabIndex='3'>»Shuttered«</a></li>
<li><a ref={linkArchitecture} href={`/${CATEGORY.path}/architecture`} tabIndex='4'>Architecture</a></li>
<li><a ref={linkEnvironment} href={`/${CATEGORY.path}/environment`} tabIndex='5'>Environment</a></li>
<li><a ref={linkFloral} href={`/${CATEGORY.path}/floral`} tabIndex='6'>Floral</a></li>
<li><a ref={linkLight} href={`/${CATEGORY.path}/light`} tabIndex='7'>Light</a></li>
<li><a ref={linkWorldmap} href='/worldmap' tabIndex='8'>Worldmap</a></li>
<li><a ref={linkContact} href='/imprint' tabIndex='9'>Contact</a></li>
<li><a ref={linkOverview} href={`/${PICTURE.path}`}>Overview</a></li>
<li><a ref={linkShuttered} href={`/${SERIES.path}/shuttered`}>»Shuttered«</a></li>
<li><a ref={linkArchitecture} href={`/${CATEGORY.path}/architecture`}>Architecture</a></li>
<li><a ref={linkEnvironment} href={`/${CATEGORY.path}/environment`}>Environment</a></li>
<li><a ref={linkFloral} href={`/${CATEGORY.path}/floral`}>Floral</a></li>
<li><a ref={linkLight} href={`/${CATEGORY.path}/light`}>Light</a></li>
<li><a ref={linkWorldmap} href='/worldmap'>Worldmap</a></li>
<li><a ref={linkContact} href='/imprint'>Contact</a></li>
</ul>
<div onClick={toggleMenu}>Menu</div>
</nav>
Expand Down
Loading