Fix "Perform all updates" task was incorrectly marked as completed #534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes "Perform all updates" is marked as completed, although I haven't updated plugins.
Sometimes also "update counter" (next to the Plugins in the Dashboard menu) was missing, then on page re-load it appeared.
This indicated that some transient probably isn't not set in time and after investigation I found that it happens after the plugin is installed through the WP Dashboard (Add plugin screen). It doesnt happen on plugin update, deactivate or delete.
update_plugins
transient, from whichwp_get_update_data
actually gets data is set onadmin_init
(with default priority), so that is the reason whyevaluate_tasks
method is bumped to that hook.Also during the install process several AJAX requests are fired, strangely not all of them fire
admin_init
hook and that is the reason why\wp_doing_ajax()
is added.