Skip to content

Fix "Perform all updates" task was incorrectly marked as completed #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025

Conversation

ilicfilip
Copy link
Collaborator

I noticed that sometimes "Perform all updates" is marked as completed, although I haven't updated plugins.
Sometimes also "update counter" (next to the Plugins in the Dashboard menu) was missing, then on page re-load it appeared.

This indicated that some transient probably isn't not set in time and after investigation I found that it happens after the plugin is installed through the WP Dashboard (Add plugin screen). It doesnt happen on plugin update, deactivate or delete.

update_plugins transient, from which wp_get_update_data actually gets data is set on admin_init (with default priority), so that is the reason why evaluate_tasks method is bumped to that hook.
Also during the install process several AJAX requests are fired, strangely not all of them fire admin_init hook and that is the reason why \wp_doing_ajax() is added.

@ilicfilip ilicfilip added this to the 1.7.0 milestone Jun 27, 2025
@ilicfilip ilicfilip requested a review from aristath June 27, 2025 09:13
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Test merged PR on Playground
Test this pull request on the Playground or download the zip.

@aristath aristath merged commit cd97d65 into develop Jun 30, 2025
19 checks passed
@aristath aristath deleted the filip/v17/fix-update-transients branch June 30, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants