-
Notifications
You must be signed in to change notification settings - Fork 1.2k
1390 Enhance DynUNet with get_feature_maps API #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1390 Enhance DynUNet with get_feature_maps API #1393
Conversation
merge master
Signed-off-by: Nic Ma <[email protected]>
/black |
Signed-off-by: Nic Ma <[email protected]>
/black |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this is a breaking change, may need to update the tutorial as well
I got an error when trying to run the DynUNet tutorial using the docker image "projectmonai/monai:latest" on 21/2/2021. "torch.nn.modules.module.ModuleAttributeError: 'DynUNet' object has no attribute 'get_feature_maps'" |
Thanks @DrAlaafeef, you're seeing this because we modified the DynUNet public interface again, see #1596. We deleted the Would you be able to create an issue on the Tutorials repository? We're currently in the process of setting up our CI/CD to automatically run all of our tutorials, so we should avoid this sort of problem in the future. @yiheng-wang-nv do you think you could take care of the Tutorials PR? |
@DrAlaafeef Alternatively, you can checkout the 0.4.0 tag for both MONAI and the tutorials to ensure they are in sync with each other. |
Fixes #1390 .
Description
As more than 3 users reported the problem with DynUNet, we need to change the return data of
forward
function.This PR added
get_feature_maps
API according to @rijobro 's suggestion in #1263 (comment).Status
Ready
Types of changes
./runtests.sh --codeformat --coverage
../runtests.sh --quick
.make html
command in thedocs/
folder.