Skip to content

1570 Fix distributed issue in ClassificationSaver #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 9, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 9, 2021

Fixes #1570 .

Description

This PR fixed the distributed issue of meta data length in ClassificationSaver hander.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma force-pushed the 1570-fix-classificationsaver branch from 4724899 to f66b2e4 Compare February 9, 2021 03:46
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 9, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 9, 2021

/black

@wyli wyli merged commit 8d70890 into Project-MONAI:master Feb 9, 2021
@Nic-Ma Nic-Ma deleted the 1570-fix-classificationsaver branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classification can't work in distributed data parallel if has rich meta data
3 participants