Throw warning when reading NRRD05 files to upgrade to ITK >= 5.2 #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Aji <[email protected]>
adamaji
force-pushed
the
reading-nrrd05
branch
2 times, most recently
from
25320d5 to
820c8f2
Compare
rijobro
reviewed
Feb 20, 2021
|
LGTM!
…---
Sent via phone.
On Sun, Feb 21, 2021, 11:48 AM Richard Brown ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In monai/data/image_reader.py
<#1602 (comment)>:
> + key == "NRRD_measurement frame"
+ and int(itk.Version.GetITKMajorVersion()) == 5
+ and int(itk.Version.GetITKMinorVersion()) < 2
I think @aylward <https://github.com/aylward> and @thewtex
<https://github.com/thewtex> would like the minimum version to be set to
itk==5.2 once that's released. In the meantime, setting it to itk==5.0 is
fine.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1602 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACEJLYHGUOWZMID5FUP5ITTAE2MDANCNFSM4X5RS7KQ>
.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adam Aji [email protected]
Fixes #1451 .
Description
Reading NRRD05 files errors out when reading the "measurement frame" field, which was addressed in InsightSoftwareConsortium/ITK#2270 thanks to @thewtex . Since the change isn't in a stable build yet, here we ignore the problem field so that the image can still be read, and throw a warning pointing users to upgrade to the release candidate version (5.2rc2) for correct loading if desired.
Status
Ready
Types of changes