Skip to content

2041 - re-enable dev branch tests #2107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Apr 28, 2021

Signed-off-by: Wenqi Li [email protected]

part of #2041

Description

enable all dev branch related tests

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@wyli wyli requested review from ericspod, Nic-Ma and rijobro April 28, 2021 18:28
@wyli wyli changed the title 2041 re-enable dev branch tests 2041 - re-enable dev branch tests Apr 28, 2021
@ericspod
Copy link
Member

ericspod commented Apr 28, 2021

Shouldn't we be running at least some of the CI/CD tests for both dev and main branches? In theory nothing should be committed to main that wasn't tested but it wouldn't hurt maybe to double check that. Also anywhere that MONAI is installed directly from the repo needs to refer to dev branch I think otherwise the main branch will be tested or deployed instead. Here I think it should refer to dev?

@wyli
Copy link
Contributor Author

wyli commented Apr 28, 2021

Shouldn't we be running at least some of the CI/CD tests for both dev and main branches? In theory nothing should be committed to main that wasn't tested but it wouldn't hurt maybe to double check that. Also anywhere that MONAI is installed directly from the repo needs to refer to dev branch I think otherwise the main branch will be tested instead.

yes, this is the part fordev branch only, this will be used for our daily pull request handling, would be great to get this running first. I'm working on the details of the main branch and the releasing related ones, they will be in another few PRs.

@ericspod ericspod merged commit 8bb08a8 into Project-MONAI:dev Apr 28, 2021
@wyli wyli deleted the 2041-branches-testing-config branch April 29, 2021 11:04
wyli added a commit that referenced this pull request May 26, 2021
wyli added a commit that referenced this pull request May 26, 2021
wyli added a commit that referenced this pull request May 26, 2021
wyli added a commit that referenced this pull request May 27, 2021
wyli added a commit that referenced this pull request May 27, 2021
wyli added a commit that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants