EfficientNet mypy fix #2126
Merged
EfficientNet mypy fix #2126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masadcv
force-pushed
the
efficientnet-mypy-fix
branch
3 times, most recently
from
b0ab4f1 to
8e41426
Compare
|
@wyli Apolpgies for messing this up, it was supposed to be an easy fix. I cannot seem to figure out how to correct DCO issue here. |
wyli
reviewed
May 1, 2021
no worries perhaps do a "git reset @~2" and commit again with -s, then push with -f |
Signed-off-by: masadcv <[email protected]>
masadcv
force-pushed
the
efficientnet-mypy-fix
branch
from
8e41426 to
13c875b
Compare
|
@wyli many thanks for help with git instructions, I fixed the commit and added a BlockArgs class with |
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: masadcv <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: masadcv <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: masadcv <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 26, 2021
Signed-off-by: masadcv <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
Signed-off-by: masadcv <[email protected]>
wyli
pushed a commit
that referenced
this pull request
May 27, 2021
Signed-off-by: masadcv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2125 .
Description
Fixes mypy error on some platforms occuring in EfficientNet BlockArgs definition.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.