2562 Add support to not save data in a separate folder

[Nic-Ma]

Fixes #2562 .

Description

According to user's feedback, this PR enhanced the nifti_saver and png_saver to optionally save every image in a separate folder or not.

Status

Ready

Types of changes

• Non-breaking change (fix or new feature that would not break existing functionality).
• Breaking change (fix or new feature that would cause existing functionality to change).
• New tests added to cover the changes.
• Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
• Quick tests passed locally by running ./runtests.sh --quick --unittests.
• In-line docstrings updated.
• Documentation updated, tested make html command in the docs/ folder.

[Nic-Ma]

/black

[ericspod]

I would suggest the default value should be False for this option to preserve existing behaviour, I personally would probably tend not to use this feature.

[Nic-Ma]

I would suggest the default value should be False for this option to preserve existing behaviour, I personally would probably tend not to use this feature.

Hi @ericspod ,

Thanks for your review and comments!
Actually, the current existing behavior in MONAI v0.6 equals True here, that's why users asked to support saving all images in the same folder.

Thanks.

[Nic-Ma]

/black

[Nic-Ma]

Hi @ericspod ,

Thanks for your review.
I updated the PR according to your comments.
Could you please help review again?

Thanks in advance.

[wyli]

not sure if this filename should also have the postfix?

[ericspod]

That will be used in the next lines for the subfolders that go in the folder referred to as output here.

[Nic-Ma]

Hi @wyli @ericspod ,

I think you mean to save as: "output/image_seg/image_seg.nii", right? The existing bahvior in MONAI is "output/image/image_seg.nii".
Maybe let me change the original logic to "output/image_seg/image_seg.nii"? Seems there is not drawback?

Thanks.