Skip to content

2627 Enhance surface metrics warning #2638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2021
Merged

2627 Enhance surface metrics warning #2638

merged 5 commits into from
Jul 21, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 21, 2021

Fixes #2627 .

Description

This PR enhanced the confusing warning messages of distance metrics.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 21, 2021

/black

@Nic-Ma Nic-Ma mentioned this pull request Jul 21, 2021
Closed
yiheng-wang-nv
yiheng-wang-nv approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think this change is better than the original implementation to avoid "duplicated" warnings when directed == False for HausdorffDistanceMetric

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 21, 2021

Hi @yiheng-wang-nv ,

Thanks for your review.
The main problem is when exchanged pred and label to compute distance, the warning message is wrong.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 21, 2021 09:25
@wyli
Copy link
Contributor

wyli commented Jul 21, 2021

/build

@Nic-Ma Nic-Ma merged commit 0266743 into Project-MONAI:dev Jul 21, 2021
rijobro added a commit that referenced this pull request Jul 22, 2021
@wyli @Nic-Ma @rijobro
merge dev into Feature/2231 transforms (#2640)
37da23e 
* 2630 adds look_up_option (#2631)

* adds look_up_options

Signed-off-by: Wenqi Li <[email protected]>

* adds docstring example

Signed-off-by: Wenqi Li <[email protected]>

* fixes tests

Signed-off-by: Wenqi Li <[email protected]>

* update enum look ups

Signed-off-by: Wenqi Li <[email protected]>

* fixes typos

Signed-off-by: Wenqi Li <[email protected]>

* update based on comments

Signed-off-by: Wenqi Li <[email protected]>

* [DLMED] enhance distance metrics warning (#2638)

Signed-off-by: Nic Ma <[email protected]>

* randweightedcrop (partially done)

Signed-off-by: Richard Brown <[email protected]>

* fixes Pad type hint

Signed-off-by: Wenqi Li <[email protected]>

Co-authored-by: Nic Ma <[email protected]>
Co-authored-by: Richard Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

@wyli wyli Awaiting requested review from wyli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SurfaceDistanceMetric (SDM) and HausdorffDistanceMetric (HDM) print wrong all-zero warning messages
3 participants
@Nic-Ma @wyli @yiheng-wang-nv