Skip to content

EnsureType, RemoveRepeatedChannel, SplitChannel, ToCupy, ToNumpy, ToPil, ToTensor, Transpose #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Aug 29, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Aug 26, 2021

Description

EnsureType, RemoveRepeatedChannel, SplitChannel, ToCupy, ToNumpy, ToPil, ToTensor, Transpose.

Requires #2840.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@rijobro rijobro requested review from wyli and Nic-Ma August 26, 2021 11:24
@rijobro rijobro changed the title Utility transforms2 EnsureType, RemoveRepeatedChannel, SplitChannel, ToCupy, ToNumpy, ToPil, ToTensor, Transpose Aug 27, 2021
@wyli
Copy link
Contributor

wyli commented Aug 27, 2021

@rijobro do you have time to resolve the merge conflicts and in PR 2859? otherwise Nic and I can fix this while you are away

@rijobro
Copy link
Contributor Author

rijobro commented Aug 27, 2021

Merge conflict taken care of, flake8 is failing but just needs one line to be deleted, would be great if you could take care of that next week. Thanks!

@wyli
Copy link
Contributor

wyli commented Aug 27, 2021

Merge conflict taken care of, flake8 is failing but just needs one line to be deleted, would be great if you could take care of that next week. Thanks!

Thank you!

Signed-off-by: Wenqi Li <[email protected]>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added option wrap_sequence to convert_to_tensor

@wyli wyli enabled auto-merge (squash) August 29, 2021 22:19
@wyli wyli merged commit c99bd41 into Project-MONAI:dev Aug 29, 2021
@rijobro rijobro deleted the utility_transforms2 branch September 9, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants