Skip to content

3971 Fix shape error information #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Mar 21, 2022

Signed-off-by: Yiheng Wang [email protected]

Fixes #3971 . This PR is used to add the missing f for the shape not match error based sentences.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <[email protected]>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Mar 21, 2022

Hi @wyli ,

Is there a way to cover this format issue in flake8 or other CI tool?

Thanks in advance.

@wyli
Copy link
Contributor

wyli commented Mar 21, 2022

/build

@wyli
Copy link
Contributor

wyli commented Mar 21, 2022

looks like an open issue @Nic-Ma ... pylint-dev/pylint#2507

@wyli wyli enabled auto-merge (squash) March 21, 2022 18:11
@wyli wyli merged commit 459b188 into Project-MONAI:dev Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs from the merged commit #3896
3 participants