Skip to content

Update default overlap value in occlusion_sensitivity to 0.6 #8446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

kavin2003
Copy link
Contributor

Fixes # .

Description

The current default overlap (0.25) in OcclusionSensitivity produces severe grid artifacts that render visualizations unusable in most cases(#8428,the 3d_classification/densenet_training_array.ipynb were created with the previous implementation(0.7.0) using stride=1 but not sliding_window).The current default prioritizes performance at the expense of basic functionality. Since a visualization tool with unusable default output fails its primary purpose, changing the default is more appropriate than requiring users to modify tutorials or discover the correct parameter values.
refernce in tutorials(v.0.7.0):
image
0.25 overleap (v.1.4):
image
0.6 overleap:
image
0.9 overleap:
image

I think a setting of 0.99 is closer to the paper and the previous implementation of stride=1, but a setting of 0.6 would be able to have a nice visual effect with a relatively small amount of computation
I couldn't find a machine that could run version 0.7, so the reference images are the ones that came with the notes rather than the ones I ran, so the heatmaps may not look the same

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@ericspod ericspod requested a review from KumoLiu May 13, 2025 11:38
@KumoLiu
Copy link
Contributor

KumoLiu commented May 13, 2025

/build

@KumoLiu KumoLiu enabled auto-merge (squash) May 13, 2025 12:46
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears fine so we can go ahead with integrating it now, and revisit this if it impacts other users if need be.

@KumoLiu KumoLiu merged commit daf9f05 into Project-MONAI:dev May 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants