Skip to content

Migrate to modern Python Logger API #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 23, 2025
Merged

Migrate to modern Python Logger API #8449

merged 3 commits into from
May 23, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

Description

This PR resolves the deprecation warnings of the logger library:

DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@emmanuel-ferdman
Migrate to modern Python Logger API
5d3530e 
Signed-off-by: Emmanuel Ferdman <[email protected]>
@ericspod ericspod requested a review from KumoLiu May 13, 2025 11:24
ericspod
ericspod approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

dzenanz
dzenanz approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@emmanuel-ferdman
Copy link
Contributor Author

thanks all for the reviews 😄
@KumoLiu could you please review this small PR when you get the chance? thanks

KumoLiu
KumoLiu approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the later response.

@KumoLiu
Copy link
Contributor

KumoLiu commented May 22, 2025

/build

@KumoLiu KumoLiu enabled auto-merge (squash) May 22, 2025 14:07
@ericspod ericspod disabled auto-merge May 22, 2025 23:16
@ericspod ericspod enabled auto-merge (squash) May 22, 2025 23:16
@KumoLiu
Copy link
Contributor

KumoLiu commented May 23, 2025

/build

1 similar comment
@KumoLiu
Copy link
Contributor

KumoLiu commented May 23, 2025

/build

@ericspod ericspod merged commit 222d509 into Project-MONAI:dev May 23, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@ericspod ericspod ericspod approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emmanuel-ferdman @KumoLiu @dzenanz @ericspod