cord/endpoint: Full rewrite of CoRE RD endpoint module #20040
+1,198
−1,193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a full rewrite of the CORD module to improve reliability, mainly by continuing registration attempts if the server for some reason stops responding.
bergzand
added
the
Process: API change
bergzand
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
github-actions
bot
added
Area: network
bergzand
force-pushed
the
pr/refactor_cord
branch
2 times, most recently
from
a56c3d6 to
0780cf3
Compare
bergzand
force-pushed
the
pr/refactor_cord
branch
from
0780cf3 to
dbe7cf0
Compare
bergzand
added
the
CI: ready for build
|
Flash usage for |
bergzand
removed
the
CI: ready for build
|
Might be relevant: #18633 |
Teufelchen1
reviewed
Nov 28, 2023
| #endif | ||
|
|
||
| #ifndef MODULE_CORD_ENDPOINT | ||
| static const char wkrd[] = "/.well-known/rd"; |
There was a problem hiding this comment.
Suggested change
| static const char wkrd[] = "/.well-known/rd"; | |
| static const char wellknown_rd[] = "/.well-known/rd"; |
| static const char wkrd[] = "/.well-known/rd"; | ||
| #endif | ||
|
|
||
| int _pkt_add_qstring(coap_pkt_t *pkt) |
There was a problem hiding this comment.
What is your reasoning for "string" in the function name?
Suggested change
| int _pkt_add_qstring(coap_pkt_t *pkt) | |
| int _pkt_add_uri_query(coap_pkt_t *pkt) |
|
|
||
| int _pkt_add_qstring(coap_pkt_t *pkt) | ||
| { | ||
| /* extend the url with some query string options */ |
There was a problem hiding this comment.
Also, why is this done?
Suggested change
| /* extend the url with some query string options */ | |
| /* extend the url with a 'key=value' query option: 'ep=cord_endpoint_name' */ |
|
|
||
| /* [optional] set the lifetime parameter */ | ||
| #if CONFIG_CORD_LT | ||
| char lt[11]; |
There was a problem hiding this comment.
Also, is 11 always long enough? Are there constraints on the lifetime (by the rfc, etc.)? Are they enforced at buildtime?
Suggested change
| char lt[11]; | |
| char lifetime[11]; |
| { | ||
| #ifndef CONFIG_CORD_ENDPOINT | ||
| if (cord_endpoint_name[0] == '\0') { | ||
| uint8_t luid[CORD_ENDPOINT_SUFFIX_LEN / 2]; |
| uint8_t luid[CORD_ENDPOINT_SUFFIX_LEN / 2]; | ||
|
|
||
| if (PREFIX_LEN > 1) { | ||
| memcpy(cord_endpoint_name, CORD_ENDPOINT_PREFIX, (PREFIX_LEN - 1)); |
There was a problem hiding this comment.
I don't think this memcpy is safe as cord_endpoint_name has different size depending on the compilation settings?
| return 0; | ||
| } | ||
|
|
||
| void _init_epname(void) |
There was a problem hiding this comment.
Suggested change
| void _init_epname(void) | |
| /* Generate a locally unique endpoint name */ | |
| void _init_epname(void) |
| { | ||
| (void)cord; | ||
| #ifdef MODULE_CORD_ENDPOINT | ||
| memset(cord->rd_regif, 0, CORD_URI_MAX); |
There was a problem hiding this comment.
Either this or the check in line 139 is wrong?
Suggested change
| memset(cord->rd_regif, 0, CORD_URI_MAX); | |
| memset(cord->rd_regif, 0, sizeof(cord->rd_regif)); |
| } | ||
| return 0; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #endif | |
| #endif /* MODULE_CORD_ENDPOINT */ |
| * @file | ||
| * @brief Standalone extension for the CoRE RD endpoint implementation | ||
| * | ||
| * @author Hauke Petersen <[email protected]> |
Closed
|
Ping? The release is coming up... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is an almost full rewrite of the CORD endpoint module in RIOT. Changes:
Testing procedure
The example modules and shell module have been adapted to work with the new module
Issues/PRs references
None