-
Notifications
You must be signed in to change notification settings - Fork 2.1k
boards/nucleo-l412kb: enable ADC #21566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ebe136e
to
7816da2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx a lot ❤️
The code looks good and I trust in your testing
Which testing 👀
But yeah, let's hope it works as it is similar enough. |
Thank you for your trust ... but as @crasbe notices I don't have this boards and only look at documentation for similar board and check if BTW. There is probably some problem with Murdock - from few days all full merge at 2 o'clock failed, in most cases due to some bizzare timeouts. Moreover, failed test for this PR is associated with timeout, too ... and I don't think that this is this PR fault. |
Yes, that error is unrelated to your code. The timing tests are a bit finnicky lately which probably correlates to load on the CI servers. I was waiting for a response from @maribu before putting it back on the queue. |
Contribution description
This PR enables ADC for
nucleo-l412kb
board.I don't have access to this boards, but because ADC pinout is the same as for
nucleo-l432kc
(see board manual tables 15 and 16) code should works fine. I compile code without any warnings.Testing procedure
Flash the board using
tests/periph/adc
andtests/periph/vbat
programs.The outputs should be similar to the ones presented in #21238 (comment)
Issues/PRs references
None.