Skip to content

riot_and_cpp: do not link on build tests for stm32f0discovery #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Dec 16, 2014

Fixes #2203

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Dec 16, 2014
@miri64 miri64 added this to the Release 2014.12 milestone Dec 16, 2014
@LudwigKnuepfer
Copy link
Member

This depends on the toolchain, right?

@OlegHahm
Copy link
Member

Apparently, yes.

@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

The toolchain I used to see this was

$ arm-none-eabi-gcc --version
arm-none-eabi-gcc (GNU Tools for ARM Embedded Processors) 4.9.3 20141119 (release) [ARM/embedded-4_9-branch revision 218278]
Copyright (C) 2014 Free Software Foundation, Inc

@LudwigKnuepfer
Copy link
Member

And it is the same as used by Travis?

@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

Since I use the same repository that travis does, I would guess so:

deb http://ppa.launchpad.net/terry.guo/gcc-arm-embedded/ubuntu trusty main

@LudwigKnuepfer
Copy link
Member

OK, then let's use this as a hot fix. Please do add a note explaining this to the Makefile.

@dangnhat
Copy link
Member

@authmillenon : could you try again with CXXEXFLAGS += -fno-exceptions -fno-rtti in the Makefile of riot_and_cpp? :-)
I can't reproduced with my toolchain

arm-none-eabi-gcc --version
arm-none-eabi-gcc (GNU Tools for ARM Embedded Processors) 4.8.4 20140526 (release) [ARM/embedded-4_8-branch revision 211358]

@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

Nope, still no sufficient RAM

$ BOARD=stm32f0discovery CXXEXFLAGS="-fno-exceptions -fno-rtti" make -C examples/riot_and_cpp/
make: Entering directory `/home/martine/Repositories/RIOT-OS/RIOT/examples/riot_and_cpp'
Building application "riot_and_cpp" for "stm32f0discovery" with MCU "stm32f0".

"make" -C /home/martine/Repositories/RIOT-OS/RIOT/boards/stm32f0discovery
"make" -C /home/martine/Repositories/RIOT-OS/RIOT/core
"make" -C /home/martine/Repositories/RIOT-OS/RIOT/cpu/stm32f0
"make" -C /home/martine/Repositories/RIOT-OS/RIOT/cpu/cortex-m0_common
"make" -C /home/martine/Repositories/RIOT-OS/RIOT/cpu/stm32f0/periph
"make" -C /home/martine/Repositories/RIOT-OS/RIOT/drivers
"make" -C /home/martine/Repositories/RIOT-OS/RIOT/sys
"make" -C /home/martine/Repositories/RIOT-OS/RIOT/sys/auto_init
/usr/bin/../lib/gcc/arm-none-eabi/4.9.3/../../../../arm-none-eabi/bin/ld: /home/martine/Repositories/RIOT-OS/RIOT/examples/riot_and_cpp/bin/stm32f0discovery/riot_and_cpp.elf section `.text' will not fit in region `rom'
/usr/bin/../lib/gcc/arm-none-eabi/4.9.3/../../../../arm-none-eabi/bin/ld: region `rom' overflowed by 3884 bytes
collect2: error: ld returned 1 exit status
make: *** [all] Error 1
make: Leaving directory `/home/martine/Repositories/RIOT-OS/RIOT/examples/riot_and_cpp'

@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

Addressed @LudwigOrtmann's comment

@dangnhat
Copy link
Member

region `rom' overflowed

it's FLASH not RAM ;-)

Anyways, I still can't reproduce and haven't got any clue yet. :)

BOARD=stm32f0discovery CXXEXFLAGS="-fno-exceptions -fno-rtti" make -C examples/riot_and_cpp/ clean all
make: Entering directory `/home/dangnhat/test/RIOT/examples/riot_and_cpp'
Building application "riot_and_cpp" for "stm32f0discovery" with MCU "stm32f0".

"make" -C /home/dangnhat/test/RIOT/boards/stm32f0discovery
"make" -C /home/dangnhat/test/RIOT/core
"make" -C /home/dangnhat/test/RIOT/cpu/stm32f0
"make" -C /home/dangnhat/test/RIOT/cpu/cortex-m0_common
"make" -C /home/dangnhat/test/RIOT/cpu/stm32f0/periph
"make" -C /home/dangnhat/test/RIOT/drivers
"make" -C /home/dangnhat/test/RIOT/sys
"make" -C /home/dangnhat/test/RIOT/sys/auto_init
   text    data     bss     dec     hex filename
  17840     112    3160   21112    5278 /home/dangnhat/test/RIOT/examples/riot_and_cpp/bin/stm32f0discovery/riot_and_cpp.elf
make: Leaving directory `/home/dangnhat/test/RIOT/examples/riot_and_cpp'

@LudwigKnuepfer LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 16, 2014
@LudwigKnuepfer
Copy link
Member

ACK unless @dangnhat wants to provide a proper solution instead.

@miri64 miri64 force-pushed the riot_and_cpp/fix/not-link-stm32f0discovery branch from a45fbf5 to 995998b Compare December 16, 2014 17:38
@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

Squashed, now waiting for travis to finish

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 16, 2014
@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

it's FLASH not RAM ;-)

I go with what the Makefile-Macro states ;-P

@dangnhat
Copy link
Member

ACK with memo tag, can't fix this now but I will look into it again when I'm done with my thesis. :-)

@dangnhat dangnhat added the State: archived State: The PR has been archived for possible future re-adaptation label Dec 16, 2014
@miri64 miri64 added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 16, 2014
@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

Oops

@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

Needs re-ACK I guess

@thomaseichinger
Copy link
Member

Please squash and remove the label. ACK, merge at will.

@LudwigKnuepfer
Copy link
Member

Travis is happy except for the squashing .. @authmillenon do it ;)

@miri64 miri64 force-pushed the riot_and_cpp/fix/not-link-stm32f0discovery branch from 7305bd9 to 58e8b75 Compare December 16, 2014 20:31
@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 16, 2014
@miri64
Copy link
Member Author

miri64 commented Dec 16, 2014

Squashed, had no merge conflicts, so go.

miri64 added a commit that referenced this pull request Dec 16, 2014
…stm32f0discovery

riot_and_cpp: do not link on build tests for stm32f0discovery
@miri64 miri64 merged commit 5c9d749 into RIOT-OS:master Dec 16, 2014
@miri64 miri64 deleted the riot_and_cpp/fix/not-link-stm32f0discovery branch December 16, 2014 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer State: archived State: The PR has been archived for possible future re-adaptation Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis: riot_and_cpp example fails for stm32f0discovery
5 participants