Create Calendar page #253
Create Calendar page #253
Conversation
NOTE: Liquid parses with RTL OOP; This is the same as: `(meeting || events || talks || (announcements && event))`
There was a problem hiding this comment.
@ct-martin I absolutely love this. The iCAL is functional and the calendar looks slick.
Before we merge this, I would just like to add links to the calendar page somewhere on the website.
|
@jrtechs I added the calendar link to the home page (replacing Talks since those are fed into the calendar as well), does that work for you? The navbar is pretty full and it might be worthwhile to make a separate issue to talk about condensing that, maybe by adding a dropdown |
Note: since RRULE can define an infinite repeat, there is an arbitrary limit of 25 in webpage rendering Uses an `rrule` frontmatter parameter to RFC spec https://icalendar.org/iCalendar-RFC-5545/3-3-6-duration.html
|
When talking with @jwflory he pointed out that proper recurring events would be nice. I added an |
| * Events (`events/`) | ||
| * Meetings & Meetups (`meetings-meetups/`) (note that these pages aren't linked from anywhere other than feeds, they are more for the metadata) | ||
| * Meetings & Meetups (`meetings-meetups/`) (Note: these are not pages; they are placeholder metadata for the calendar feed and should be deleted when creating the announcement post) |
There was a problem hiding this comment.
what does this mean? Does this require additional metadata when creating announcement posts?
There was a problem hiding this comment.
The "pages" in that folder should be entirely metadata and are meant to be used for the Calendar feed generation only. E.g., meetings that haven't had a topic or speaker determined yet and thus have no announcement nor talk page. These use the same metadata that the rest of the site has available, but tends to utilize some functionality more heavily, e.g. redirect page type. Technically you could use these as real pages, but I would discourage that in favor of other sections of the site, namely, announcements, talks, and events.
| @@ -28,7 +28,7 @@ <h2>Discuss</h2> | |||
| <h2>Do</h2> | |||
| <div class="list-group"> | |||
| <a href="/get-involved" class="list-group-item list-group-item-action">Get Involved</a> | |||
| <a href="/talks" class="list-group-item list-group-item-action">Talks</a> | |||
| <a href="/calendar" class="list-group-item list-group-item-action">Calendar</a> | |||
There was a problem hiding this comment.
So does the calendar replace the Talks tab?
There was a problem hiding this comment.
On the home page list, not the navbar. The navbar is already really full so I opted to not add more to it. I think further linking/navbar changes would be best for another issue/PR
There was a problem hiding this comment.
the talks tab is still on the page's main navbar
There was a problem hiding this comment.
Yes, that was part of what I meant; this is intended behavior and not a bug
|
@ct-martin I like these changes, as a future issue I think we could do a ritlug website 101 where we explain what needs to be done for the following things:
Still not fully convinced whether this should be in the run book or this repo. |
From my point-of-view, the answer depends if you expect this to be a task almost exclusively done by eboard (i.e. Runbook) or if you want to open it up more widely to the community (i.e. contributing guidelines for this repo). |
|
@jrtechs given that we have presenters add talks sometimes I think it should be in the repo. There has been prior conversation in issues about README vs CONTRIBUTING and so on for some of this. I think this would be better to have as an in-person conversation at FOSS Hours or RITlug. Feel free to create/update an issue and assign it to me |
meetings-meetups/folder is about (fixes Document iCal feed update process #202)cc @jrtechs @Tjzabel @jwflory