Support forcing of IPv4/IPv6 resolution. #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new --ipv4 (-4) and --ipv6 (-6) command line options to force address resolution. The default value is unspecified, and we will try resolving both.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 56.97% 56.87% -0.11%
==========================================
Files 21 21
Lines 4270 4283 +13
==========================================
+ Hits 2433 2436 +3
- Misses 1837 1847 +10
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yossigo
reviewed
Apr 23, 2023
memtier_benchmark.cpp
Outdated
| @@ -203,6 +205,7 @@ static void config_print_to_json(json_handler * jsonhandler, struct benchmark_co | |||
| jsonhandler->write_obj("server" ,"\"%s\"", cfg->server); | |||
| jsonhandler->write_obj("port" ,"%u", cfg->port); | |||
| jsonhandler->write_obj("unix socket" ,"\"%s\"", cfg->unix_socket); | |||
| jsonhandler->write_obj("resolution" ,"\"%s\"", cfg->resolution == AF_UNSPEC ? "Unspecified" : cfg->resolution == AF_INET ? "AF_INET" : "AF_INET6"); | |||
There was a problem hiding this comment.
The name resolution is a bit unclear in this context, I suggest to refer to it as "address family".
yossigo
previously approved these changes
Apr 23, 2023
resolution -> address family
yossigo
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new --ipv4 (-4) and --ipv6 (-6) command line options to force address resolution.
The default value is unspecified, and we will try resolving both.