Skip to content

root element of external schema ref files cannot be same name as any property of JsonSchema#1336

Open
jimfrederic wants to merge 1 commit intoRicoSuter:masterfrom
jimfrederic:ExternalRefRootElementPropertyOfJsonSchema
Open

root element of external schema ref files cannot be same name as any property of JsonSchema#1336
jimfrederic wants to merge 1 commit intoRicoSuter:masterfrom
jimfrederic:ExternalRefRootElementPropertyOfJsonSchema

Conversation

@jimfrederic
Copy link
Copy Markdown

No solution, just a failing test case to reproduce the problem.

@RicoSuter
Copy link
Copy Markdown
Owner

RicoSuter commented Mar 5, 2021

schema_named_title.yaml is not a valid JSON Schema...
Is this even supposed to work (ie. should this be allowed)?

@jimfrederic
Copy link
Copy Markdown
Author

schema_named_title.yaml is not a valid JSON Schema...
Is this even supposed to work (ie. should this be allowed)?

The example is contrived, admittedly, cut down from a real-world OpenApi document to minimize it. So take a similar example: If you modify an existing test, changing myBool to Title here in collection.json and here in schema_with_collection_reference.json, then the test case When_schema_references_collection_in_definitions_it_works throws the same exception while parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants