Let non-required, nullable properties of Record classes be C#-optiona… #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

adamjones2 wants to merge 3 commits into RicoSuter:master from adamjones2:optional-parameters

Open

Let non-required, nullable properties of Record classes be C#-optiona… #1665

Update PropertyModel.cs

Annotations

10 errors and 3 warnings

[xUnit.net 00:00:01.95] NJsonSchema.CodeGeneration.CSharp.Tests.GeneralGeneratorTests.When_native_record_no_setter_in_class_and_constructor_provided [FAIL]

_/src/NJsonSchema.CodeGeneration.CSharp.Tests/GeneralGeneratorTests.cs#L1822

Assert.Contains() Failure: Sub-string not found String: "//----------------------\n// <auto-generat"··· Not found: "public Address(string @city, string @stre"···

[xUnit.net 00:00:03.10] NJsonSchema.CodeGeneration.CSharp.Tests.GeneralGeneratorTests.When_class_is_abstract_constructor_is_protected_for_record [FAIL]

_/src/NJsonSchema.CodeGeneration.CSharp.Tests/GeneralGeneratorTests.cs#L1870

Assert.Contains() Failure: Sub-string not found String: "//----------------------\n// <auto-generat"··· Not found: "protected AbstractAddress(string @city, s"···

[xUnit.net 00:00:03.24] NJsonSchema.CodeGeneration.CSharp.Tests.GeneralGeneratorTests.When_property_name_is_created_by_custom_fun_then_parameter_name_is_correct_for_record [FAIL]

[xUnit.net 00:00:03.24] NJsonSchema.CodeGeneration.CSharp.Tests.GeneralGeneratorTests.When_record_no_setter_in_class_and_constructor_provided [FAIL]

_/src/NJsonSchema.CodeGeneration.CSharp.Tests/GeneralGeneratorTests.cs#L177

Assert.Contains() Failure: Sub-string not found String: "//----------------------\n// <auto-generat"··· Not found: "public Address(string @myCustomCity, stri"···

_/src/NJsonSchema.CodeGeneration.CSharp.Tests/GeneralGeneratorTests.cs#L1797

Assert.Contains() Failure: Sub-string not found String: "//----------------------\n// <auto-generat"··· Not found: "public Address(string @city, string @stre"···

[xUnit.net 00:00:03.28] NJsonSchema.CodeGeneration.CSharp.Tests.GeneralGeneratorTests.When_record_has_inheritance [FAIL]

_/src/NJsonSchema.CodeGeneration.CSharp.Tests/GeneralGeneratorTests.cs#L1889

Assert.Contains() Failure: Sub-string not found String: "//----------------------\n// <auto-generat"··· Not found: "protected AbstractAddress(string @city, s"···

Attempting second-chance registration of MSBuild after RegisterDefaults failed

Could not register MSBuild: "Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. "

Exception was suppressed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Let non-required, nullable properties of Record classes be C#-optiona… #1665

Uh oh!

Uh oh!

Let non-required, nullable properties of Record classes be C#-optiona… #1665

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...

Uh oh!

Let non-required, nullable properties of Record classes be C#-optiona… #1665

Are you sure you want to change the base?

Uh oh!

Update PropertyModel.cs

Uh oh!

Let non-required, nullable properties of Record classes be C#-optiona… #1665

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...