Add IntegerType setting to CSharpGeneratorSettings#1889
Open
Add IntegerType setting to CSharpGeneratorSettings#1889
Conversation
Co-authored-by: lahma <171892+lahma@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for IntegerType in CSharpGeneratorSettings
Add IntegerType setting to CSharpGeneratorSettings
Mar 1, 2026
RicoSuter
reviewed
Mar 8, 2026
| return isNullable ? "long?" : "long"; | ||
| } | ||
|
|
||
| if (schema.Format is JsonFormatStrings.Long or "long") |
Owner
There was a problem hiding this comment.
I think we should keep this one, no? Breaking change otherwise.
Collaborator
There was a problem hiding this comment.
I think this branch is duplicated just above, so basically removing one of them doesn't matter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSharpGeneratorSettingshad configurable type mappings for numbers, dates, and collections but no equivalent forinteger, making it impossible to default tolonginstead ofintglobally.Changes
CSharpGeneratorSettings: AddedIntegerTypeproperty (default:"int") alongside the existing numeric type settingsCSharpTypeResolver.ResolveInteger: Changed fromstaticto instance method; usesSettings.IntegerTypeas the default fallback (guards against null/whitespace with"int"). Also removed a duplicatelongformat branch that existed in the original codeintgeneration and custom type overrideUsage
Note: this setting applies only to integer properties with no explicit format —
byte,long(int64 format), andulongformat mappings are unaffected.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.