Fix circular and deep external $ref resolution causing hangs#1903
Open
lahma wants to merge 1 commit intoRicoSuter:masterfrom
Open
Fix circular and deep external $ref resolution causing hangs#1903lahma wants to merge 1 commit intoRicoSuter:masterfrom
lahma wants to merge 1 commit intoRicoSuter:masterfrom
Conversation
Resolves issues where schemas with circular external file/URL $ref chains (e.g. FHIR schemas, Azure ARM schemas) cause infinite recursion or timeouts during UpdateSchemaReferencesAsync. Changes to JsonReferenceResolver: - Add _inProgressDocuments tracking to detect when a document is already being resolved up the call stack, breaking circular resolution chains - Normalize document paths consistently via NormalizeDocumentPath() to prevent cache misses from path representation differences - When a circular reference is detected, return the pre-registered (deserialized but not yet fully resolved) schema from AddDocumentReference Fixes RicoSuter#618, RicoSuter#616, RicoSuter#588, RicoSuter#566 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_inProgressDocumentsHashSet toJsonReferenceResolverthat detects when a document is already being resolved up the call stack, returning the pre-registered (deserialized but not yet fully resolved) schema instead of recursing infinitelyNormalizeDocumentPath()— URLs are normalized withUri.GetLeftPart(UriPartial.Path)and file paths withPath.GetFullPath()— preventing cache misses from path representation differencesFixes #618, #616, #588, #566
Test plan
LazyReferenceResolutionTestspass (including timeout-guarded circular ref tests)🤖 Generated with Claude Code