Fix IPv4 format validator regex false positives#1909
Merged
lahma merged 1 commit intoRicoSuter:masterfrom Mar 9, 2026
Merged
Conversation
Escape dot character in regex to match literal dots only, preventing strings like '00:45:00.0' from passing validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RicoSuter
added a commit
that referenced
this pull request
Mar 29, 2026
Migrate new FormatIpV4Tests from master (JValue -> JsonValue.Create) after merging Fix IPv4 format validator regex false positives (#1909).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.→\.) in the IPv4 validation regex to match only literal dots"00:45:00.0"or"1:2:3:4"incorrectly passed IPv4 validation because the unescaped.matches any characterFixes #1409
Test plan
"192.168.0.1"valid,"test"invalid)"00:45:00.0"correctly rejected"1:2:3:4"correctly rejected"256.1.1.1"correctly rejected🤖 Generated with Claude Code