Skip StringLength attribute for date/time properties#1911
Open
lahma wants to merge 1 commit intoRicoSuter:masterfrom
Open
Skip StringLength attribute for date/time properties#1911lahma wants to merge 1 commit intoRicoSuter:masterfrom
lahma wants to merge 1 commit intoRicoSuter:masterfrom
Conversation
Do not emit [StringLength] on properties with date-time, date, or time format, as the attribute is only meaningful for string types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[StringLength]on properties withdate-time,date, ortimeformat, as the attribute is only meaningful for string typesformat: date-timeandminLength/maxLengthwould generate a[StringLength]attribute on aDateTimeOffsetproperty, which is semantically invalidFixes #1373
Test plan
format: date-time+minLength/maxLengthdoes NOT emit[StringLength][StringLength]tests for string properties still pass (13 tests total)🤖 Generated with Claude Code