Nonlinearsolve tests #2573
Merged
Nonlinearsolve tests #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
added a commit
to oscardssmith/OrdinaryDiffEq.jl
that referenced
this pull request
May 21, 2025
oscardssmith
added a commit
that referenced
this pull request
May 22, 2025
fix NonlinearSolve tests (broken by #2573)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request re-enables unit tests for the NonlinearSolve subpackage in gitlab CI, and fixes the failing tests (by loosening assert tolerances).
See #2572
If the pipeline passes and CI looks good, then it should be ready for review.