Skip to content

7-zip: script to install explorer context menu#2779

Merged
issaclin32 merged 1 commit intoScoopInstaller:masterfrom
faabiosr:master
Oct 22, 2021
Merged

7-zip: script to install explorer context menu#2779
issaclin32 merged 1 commit intoScoopInstaller:masterfrom
faabiosr:master

Conversation

@faabiosr
Copy link
Copy Markdown
Contributor

Setup the 7zip context menu reg files.

@idbrii
Copy link
Copy Markdown
Contributor

idbrii commented Oct 20, 2021

Some fallout I experienced from #846 was that the scripts people were using to update the installer version broke after changing the number of urls it downloaded. You may want to track down who updates the 7zip version and ping them here.

Nice work!

@faabiosr
Copy link
Copy Markdown
Contributor Author

Thanks @idbrii

@issaclin32
Copy link
Copy Markdown
Member

I would suggest following the pattern of VSCode and GrepWin.

That is, renaming install-7zip.reg and uninstall-7zip.reg to 7zip-install-context.reg and 7zip-uninstall-context.reg.

https://github.com/lukesampson/scoop-extras/tree/master/scripts

@faabiosr
Copy link
Copy Markdown
Contributor Author

faabiosr commented Oct 21, 2021

Thanks for the tip @issaclin32, honestly, I am not sure if I should change following the scoop-extras, the Main has a different structure. Additionally I followed the python package.

Although, if it is one of the repository requirements that I did not realize, I will change it.

@issaclin32
Copy link
Copy Markdown
Member

issaclin32 commented Oct 21, 2021

honestly, I am not sure if I should change following the scoop-extras, the Main has a different structure. Additionally I followed the python package.

I see your point. Actually the extras bucket is maintained by the same team previously. (and apply almost the same criteria for manifests)
I am not sure why extras bucket was not moved into ScoopInstaller.

The only concern is the naming. python package uses install-pep-514.reg, rather than something vague like install-python.reg.

You can rename install-7zip.reg to install-context.reg, or whatever you want. Just need to keep the name clear to users.

@faabiosr faabiosr force-pushed the master branch 2 times, most recently from ef657fa to 84ac54d Compare October 22, 2021 09:44
@issaclin32 issaclin32 merged commit a5188a4 into ScoopInstaller:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants