Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-30048: CSM Logs#895

Merged
pawankumarsrivastava merged 17 commits into
Seagate:mainfrom
ShivamVerma380:CORTX30048_CSMLogs
Aug 30, 2022
Merged

CORTX-30048: CSM Logs#895
pawankumarsrivastava merged 17 commits into
Seagate:mainfrom
ShivamVerma380:CORTX30048_CSMLogs

Conversation

@ShivamVerma380
Copy link
Copy Markdown
Contributor

@ShivamVerma380 ShivamVerma380 commented Aug 23, 2022 •
edited
Loading

Pull Request

Problem Statement

  • CSM| Log improvement
  • JIRA Refrence: CORTX-30048

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM
    Build Status:
    custom-ci-build:
    image

Logs:
image
Create CSM User and Fetch CSM Users:
image
Get Users By UserId:
image
Delete Users By UserId:
image
Request Id in SessionLogs:
image

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Shivam Verma added 4 commits August 23, 2022 07:26
Added request_id field in existing logs in login.py
516287b 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Added request_id field in existing logs of api.py
a796424 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Added request_id field in existing logs of users.py
f515e9a 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Added logs in storage_capacity.py
4be0529 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented Aug 23, 2022

Thanks for your contribution!
The CLA bot has flagged your contribution as not having a Contributor License Agreement
in place. Note that this is not needed in the overwhelming majority of instances and this warning will usually be ignored.
The code reviewers will make a determination and may ask you to sign a CLA or may choose to ignore this warning.
More information about this can be found here.

@cortx-admin
Copy link
Copy Markdown

cortx-admin commented Aug 23, 2022

Can one of the admins verify this patch?

@ShivamVerma380 ShivamVerma380 marked this pull request as ready for review August 24, 2022 03:54
@ShivamVerma380 ShivamVerma380 changed the title Cortx30048 CSM Logs Cortx:30048-CSM Logs Aug 24, 2022
@ShivamVerma380 ShivamVerma380 changed the title Cortx:30048-CSM Logs Cortx-30048:CSM Logs Aug 24, 2022
Added request_id field in middlewares in api.py
9ad404d 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
@cla-bot cla-bot Bot added the cla-signed label Aug 24, 2022
Shivam Verma added 3 commits August 24, 2022 02:07
Added request_id in authorization failed log in api.py
c2c12ba 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Added request_id in login logs in sessions.py
6b3c4c6 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Removed request_id field in sessions.py
5526f94 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
@ShivamVerma380 ShivamVerma380 changed the title Cortx-30048:CSM Logs Cortx-30048: CSM Logs Aug 25, 2022
@ShivamVerma380 ShivamVerma380 changed the title Cortx-30048: CSM Logs CORTX-30048: CSM Logs Aug 25, 2022
rohitkolapkar
rohitkolapkar suggested changes Aug 25, 2022
View reviewed changes
Comment thread csm/core/controllers/storage_capacity.py
Comment thread csm/core/agent/api.py Outdated
Comment thread csm/core/controllers/login.py Outdated
Comment thread csm/core/controllers/rgw/s3/users.py Outdated
Comment thread csm/core/controllers/users.py Outdated
Comment thread csm/core/services/sessions.py Outdated
Comment thread csm/core/services/storage_capacity.py Outdated
Shivam Verma added 4 commits August 24, 2022 23:37
Merge branch 'main' of https://github.com/Seagate/cortx-manager into …
fe26d11 
…CORTX30048_CSMLogs

Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>

Conflicts:
csm/core/controllers/storage_capacity.py
Added request_id field in S3 Tenant logs
e04e9f8 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Added new line at end of file api.py and sessions.py
f3fb28b 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Merge branch 'main' of https://github.com/Seagate/cortx-manager into …
72a6c77 
…CORTX30048_CSMLogs

Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Shivam Verma and others added 5 commits August 29, 2022 22:52
Added new line at end of storage_capacity.py
5d6a975 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Removed extra line at end of storage_capacity.py
4ef0890 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Added new lines at end of requested files
8cb3018 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
Added new lines at end of requested files
4f84010 
Signed-off-by: Shivam Verma <shivam.r.verma@seagate.com>
@pawankumarsrivastava
Merge branch 'main' into CORTX30048_CSMLogs
7ca0f8f
@pawankumarsrivastava pawankumarsrivastava merged commit 8b256dc into Seagate:main Aug 30, 2022
@welcome
Copy link
Copy Markdown

welcome Bot commented Aug 30, 2022

Thanks for your contribution to CORTX! 🎉

@rohitkolapkar rohitkolapkar mentioned this pull request Sep 1, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ajaysrivas ajaysrivas Awaiting requested review from ajaysrivas

@kupranay kupranay Awaiting requested review from kupranay

2 more reviewers

@rohitkolapkar rohitkolapkar rohitkolapkar approved these changes

@pawankumarsrivastava pawankumarsrivastava pawankumarsrivastava approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soniyamoholkar soniyamoholkar

@pawankumarsrivastava pawankumarsrivastava

@ajaysrivas ajaysrivas

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ShivamVerma380 @cortx-admin @rohitkolapkar @pawankumarsrivastava @soniyamoholkar @ajaysrivas