CORTX-30751: Codacy code cleanup (#1606) by alfhad · Pull Request #1896 · Seagate/cortx-motr

alfhad · 2022-06-17T12:45:09Z

This patch fixes some of the codacy warnings.
warning fixed : "Double quote to prevent globing and words splitting".

Signed-off-by: alfhad fahadshah2411@gmail.com

Problem Statement

We see 1688 occurrence of pattern, "Double quote to prevent globing and words splitting".

Design

We are putting the variable references in double quotes.

Coding

Checklist for Author

Coding conventions are followed and code is consistent

Testing

Checklist for Author

Unit and System Tests are added
Test Cases cover Happy Path, Non-Happy Path and Scalability
Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

Interface change (if any) are documented
Side effects on other features (deployment/upgrade)
Dependencies on other component(s)

Review Checklist

Checklist for Author

JIRA number/GitHub Issue added to PR
PR is self reviewed
Jira and state/status is updated and JIRA is updated with PR link
Check if the description is clear and explained

Documentation

Checklist for Author

Changes done to WIKI / Confluence page / Quick Start Guide

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <fahadshah2411@gmail.com>

cortx-admin · 2022-06-17T12:51:05Z

Can one of the admins verify this patch?

cortx-admin · 2022-06-17T23:10:54Z

Jenkins CI Result : Motr#1352

Motr Test Summary

Test Result	Count	Info
❌Failed	3	📁 01motr-single-node/52motr-singlenode-sanity 03motr-single-node/71spiel-sns-motr-repair 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	40	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/48motr-raid0-io 04motr-single-node/49motr-rpc-cancel 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	75	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

stale · 2022-06-22T22:46:35Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

rkothiya

LGTM

rkothiya · 2022-06-30T15:16:30Z

run vm-deployment

rkothiya · 2022-07-02T10:54:07Z

ok to test

stale · 2022-07-07T02:10:39Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

stale · 2022-07-31T07:32:22Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

stale · 2022-08-16T03:42:41Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

rkothiya · 2022-08-23T18:49:29Z

Jenkins CI Result : Motr#1625

Motr Test Summary

Test Result	Count	Info
❌Failed	2	📁 04motr-single-node/49motr-rpc-cancel 01motr-single-node/00userspace-tests
🏁Skipped	32	📁 01motr-single-node/28sys-kvs 01motr-single-node/35m0singlenode 01motr-single-node/04initscripts 01motr-single-node/37protocol 02motr-single-node/51kem 02motr-single-node/20rpc-session-cancel 02motr-single-node/10pver-assign 02motr-single-node/21fsync-single-node 02motr-single-node/13dgmode-io 02motr-single-node/14poolmach 02motr-single-node/11m0t1fs 02motr-single-node/26motr-user-kernel-tests 02motr-single-node/08spiel 03motr-single-node/06conf 03motr-single-node/36spare-reservation 04motr-single-node/34sns-repair-1n-1f 04motr-single-node/08spiel-sns-repair-quiesce 04motr-single-node/28sys-kvs-kernel 04motr-single-node/11m0t1fs-rconfc-fail 04motr-single-node/08spiel-sns-repair 04motr-single-node/19sns-repair-abort 04motr-single-node/22sns-repair-ios-fail 05motr-single-node/18sns-repair-quiesce 05motr-single-node/12fwait 05motr-single-node/16sns-repair-multi 05motr-single-node/07mount-fail 05motr-single-node/15sns-repair-single 05motr-single-node/23sns-abort-quiesce 05motr-single-node/17sns-repair-concurrent-io 05motr-single-node/07mount 05motr-single-node/07mount-multiple 05motr-single-node/12fsync
✔️Passed	43	📁 01motr-single-node/43m0crate 01motr-single-node/05confgen 01motr-single-node/06hagen 01motr-single-node/52motr-singlenode-sanity 01motr-single-node/01net 01motr-single-node/01kernel-tests 01motr-single-node/03console 01motr-single-node/02rpcping 02motr-single-node/07m0d-fatal 02motr-single-node/67fdmi-plugin-multi-filters 02motr-single-node/53clusterusage-alert 02motr-single-node/41motr-conf-update 03motr-single-node/61sns-repair-motr-1n-1f 03motr-single-node/72spiel-sns-motr-repair-quiesce 03motr-single-node/08spiel-multi-confd 03motr-single-node/69sns-repair-motr-quiesce 03motr-single-node/62sns-repair-motr-mf 03motr-single-node/70sns-failure-after-repair-quiesce 03motr-single-node/63sns-repair-motr-1k-1f 03motr-single-node/60sns-repair-motr-1f 03motr-single-node/66sns-repair-motr-abort-quiesce 03motr-single-node/24motr-dix-repair-lookup-insert-spiel 03motr-single-node/68sns-repair-motr-shutdown 03motr-single-node/64sns-repair-motr-ios-fail 03motr-single-node/71spiel-sns-motr-repair 03motr-single-node/24motr-dix-repair-lookup-insert-m0repair 03motr-single-node/04sss 03motr-single-node/65sns-repair-motr-abort 04motr-single-node/73motr-io-small-disks 04motr-single-node/48motr-raid0-io 04motr-single-node/74motr-di-corruption-detection 04motr-single-node/25m0kv 04motr-single-node/44motr-rm-lock-cc-io 04motr-single-node/45motr-rmw 05motr-single-node/23dix-repair-m0repair 05motr-single-node/43motr-sync-replication 05motr-single-node/42motr-utils 05motr-single-node/45motr-sns-repair-N-1 05motr-single-node/40motr-dgmode 05motr-single-node/23dix-repair-quiesce-m0repair 05motr-single-node/23spiel-dix-repair-quiesce 05motr-single-node/44motr-sns-repair 05motr-single-node/23spiel-dix-repair
Total	77	🔗

CppCheck Summary

Cppcheck: No new warnings found 👍

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <fahadshah2411@gmail.com>

CORTX-30751: Codacy code cleanup (Seagate#1606)

2b37ef7

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <fahadshah2411@gmail.com>

alfhad requested review from andriytk, huanghua78, ivan-alekhin, madhavemuri, mehjoshi, nikitadanilov, nkommuri, rkothiya, sergey-shilov, sg-shankar, shashank-parulekar, siningwuseagate, vidyadhar-pinglikar and yeshpal-jain-seagate as code owners June 17, 2022 12:45

cla-bot Bot added the cla-signed label Jun 17, 2022

stale Bot added the needs-attention label Jun 22, 2022

Merge branch 'main' into issue-1606-p3

e9d27df

rkothiya approved these changes Jun 23, 2022

View reviewed changes

stale Bot removed the needs-attention label Jun 23, 2022

stale Bot added the needs-attention label Jul 7, 2022

rkothiya self-requested a review July 27, 2022 04:31

stale Bot removed the needs-attention label Jul 27, 2022

rkothiya reviewed Jul 27, 2022

View reviewed changes

Comment thread st/stob_domain_recreate_on_corruption.sh Outdated

rkothiya self-requested a review July 27, 2022 04:34

stale Bot added the needs-attention label Jul 31, 2022

hessio added the codacy label Aug 9, 2022

stale Bot removed the needs-attention label Aug 9, 2022

hessio added the Status: Waiting to be Reviewed PR is waiting for reviewers to review the PR label Aug 9, 2022

huanghua78 reviewed Aug 11, 2022

View reviewed changes

Comment thread st/stob_domain_recreate_on_corruption.sh Outdated

stale Bot added the needs-attention label Aug 16, 2022

alfhad requested a review from yatin-mahajan as a code owner August 23, 2022 12:41

Merge branch 'main' into issue-1606-p3

303576a

alfhad force-pushed the issue-1606-p3 branch from a23fa73 to 303576a Compare August 23, 2022 12:44

alfhad requested review from huanghua78 and rkothiya and removed request for huanghua78, ivan-alekhin, rkothiya and sergey-shilov August 23, 2022 12:45

huanghua78 approved these changes Aug 24, 2022

View reviewed changes

rkothiya merged commit c077e53 into Seagate:main Aug 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CORTX-30751: Codacy code cleanup (#1606)#1896

CORTX-30751: Codacy code cleanup (#1606)#1896
rkothiya merged 3 commits into
Seagate:mainfrom
alfhad:issue-1606-p3

alfhad commented Jun 17, 2022

Uh oh!

cortx-admin commented Jun 17, 2022

Uh oh!

cortx-admin commented Jun 17, 2022

Uh oh!

stale Bot commented Jun 22, 2022

Uh oh!

rkothiya left a comment

Uh oh!

rkothiya commented Jun 30, 2022

Uh oh!

rkothiya commented Jul 2, 2022

Uh oh!

stale Bot commented Jul 7, 2022

Uh oh!

Uh oh!

stale Bot commented Jul 31, 2022

Uh oh!

Uh oh!

stale Bot commented Aug 16, 2022

Uh oh!

rkothiya commented Aug 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

alfhad commented Jun 17, 2022

Problem Statement

Design

Coding

Testing

Impact Analysis

Review Checklist

Documentation

Uh oh!

cortx-admin commented Jun 17, 2022

Uh oh!

cortx-admin commented Jun 17, 2022

Jenkins CI Result : Motr#1352

Motr Test Summary

CppCheck Summary

Uh oh!

stale Bot commented Jun 22, 2022

Uh oh!

rkothiya left a comment

Choose a reason for hiding this comment

Uh oh!

rkothiya commented Jun 30, 2022

Uh oh!

rkothiya commented Jul 2, 2022

Uh oh!

stale Bot commented Jul 7, 2022

Uh oh!

Uh oh!

stale Bot commented Jul 31, 2022

Uh oh!

Uh oh!

stale Bot commented Aug 16, 2022

Uh oh!

rkothiya commented Aug 23, 2022

Jenkins CI Result : Motr#1625

Motr Test Summary

CppCheck Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants