Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-34050: Apply limit_time filter on .gz files.#876

Merged
cdeshmukh merged 2 commits into
Seagate:mainfrom
shriya-deshmukh:CORTX-34050
Aug 30, 2022
Merged

CORTX-34050: Apply limit_time filter on .gz files.#876
cdeshmukh merged 2 commits into
Seagate:mainfrom
shriya-deshmukh:CORTX-34050

Conversation

@shriya-deshmukh
Copy link
Copy Markdown
Contributor

@shriya-deshmukh shriya-deshmukh commented Aug 30, 2022

Problem Statement

  • Handle processing for .gz files while applying the limit_time filter.

Design

  • For Bug describe the fix here.
  • For Feature, Post the link to the solution page on the confluence CORTX Foundation Library

Coding

  • Coding conventions are followed and code is consistent [Y/N]: Y
  • Confirm All CODACY errors are resolved [Y/N]: Y

Testing

  • Are test cases updated along with code changes due to Enhancements/Bugs [Y/N]:
  • Confirm that new test cases are added to regression and sanity plan files and relevant feature plan files [Y/N]:
  • Confirm that Test Cases are added for new features added [Y/N]:
  • Confirm Test Cases cover Happy Path, Non-Happy Path and Scalability [Y/N]:
  • Confirm Testing was performed with installed RPM/K8s deployment [Y/N]: Y

Review Checklist

Before posting the PR please ensure:

  • PR is self reviewed
  • Is there a change in filename/package/module or signature [Y/N]:
  • If yes for above point, Is a notification sent to all other cortx components [Y/N]
  • New package/s added to setup.py?
  • Jira is updated
  • Check if the description is clear and explained.
  • Check Acceptance Criterion is defined.
  • All the tests performed should be mentioned before Resolving a JIRA.
  • Verification needs to be done before marked as Closed/Verified.

KVstore/Confstore feature (changes/fixes) checklist

Confirm changes are made for:

  • ConfStore
  • KVStore
  • ConfCli
  • Test cases added for all above 3
  • changes done in all the KVpayloads (ConsulKvPayload, IniKvPayload, KvPayload)

Documentation

  • Changes done to WIKI / Confluence page

Signed-off-by: Shriya Deshmukh <shriya.deshmukh@seagate.com>
Copy link
Copy Markdown
Contributor

@sachitanands sachitanands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Comment thread py-utils/src/utils/support_framework/log_filters.py
Comment thread py-utils/src/utils/support_framework/log_filters.py
Comment thread py-utils/src/utils/support_framework/log_filters.py
Comment thread py-utils/src/utils/support_framework/log_filters.py
Comment thread py-utils/src/utils/support_framework/log_filters.py
Comment thread py-utils/src/utils/support_framework/log_filters.py Outdated
Signed-off-by: Shriya Deshmukh <shriya.deshmukh@seagate.com>
@cdeshmukh cdeshmukh merged commit 2f726f0 into Seagate:main Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants