-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[dotnet] [bidi] Address BiDi's JSON converter AOT warnings #15390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍(Review updated until commit 9491f5a)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 9491f5a
Previous suggestionsSuggestions up to commit 27cdb89
|
...c/webdriver/BiDi/Communication/Json/Converters/Enumerable/GetClientWindowsResultConverter.cs
Outdated
Show resolved
Hide resolved
…into bidi-AOT
I see 2 options:
I am not sure which way is better. I propose to hold on it until #15329 is resolved. Then we will understand how to "extend" serializer context, and will apply more accurate decision here. |
OK, I will break off the enum string changes until a decision is made there. Everything else should still be valid. |
Only question this PR brought up: I removed those changes from this PR. Everything else should be straightforward. If we merge this PR, we can enable AOT warnings on the project as a whole, making AOT questions much simpler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me mark this PR with changes required, seems there is better way how to resolve this warning (please see inline comment, I didn't verify it). Thanks for understanding, we should research it before introducing new rule. I hope we just miss something, time to learn.
…into pr/15390
Using the overload with |
User description
Description
Addresses warnings users face when trying to publish BiDi code to AOT.
Motivation and Context
These warnings are actually user-facing. Users will see this when running
dotnet publish
with AOT enabled; we should do our best from surfacing them.Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Added AOT-safe annotations to JSON converters for BiDi modules.
Improved handling of JSON serialization in
Command
class.Enhanced error handling and compatibility in
ChromiumDriver
and utilities.Reduced unnecessary warnings during AOT compilation.
Changes walkthrough 📝
13 files
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT-safe annotations to JSON converter
Added AOT compatibility annotations to DevTools session handling
2 files
Improved JSON serialization and deserialization logic
Enhanced null-checking for assembly location handling