Skip to content

[py] Upgrade dependencies for mypy tox environment #15642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Apr 19, 2025

User description

💥 What does this PR do?

This PR upgrades the dependencies for the mypy environment in py/tox.ini (this is what we use for type checking).

This includes the latest versions of:

  • mypy
  • lxml
  • trio-typing

(all other dependencies were already at the latest version)

The reason for this change is because the old version of lxml would not build on Python 3.12 and 3.13, making it inconvenient to run locally. The new set of dependencies work correctly on all versions of Python we support (3.9 - 3.13).

💡 Additional Considerations

This PR doesn't fix any of the 128 errors MyPy currently finds (this really needs some attention).

This PR shouldn't affect CI because we don't fail CI runs when the Mypy workflow job fails.

The job runs:

tox -c py/tox.ini -- --cobertura-xml-report ci || true

... which returns true when the job fails.

🔄 Types of changes

  • Dependency upgrade for type checking

PR Type

enhancement, other


Description

  • Upgraded mypy dependency to version 1.15.0.

  • Updated lxml dependency to version 5.3.2.

  • Upgraded trio-typing dependency to version 0.10.0.

  • Ensured compatibility with Python versions 3.9 to 3.13.


Changes walkthrough 📝

Relevant files
Dependencies
tox.ini
Upgrade dependencies in `mypy` tox environment                     

py/tox.ini

  • Updated mypy version from 1.4.1 to 1.15.0.
  • Updated lxml version from 4.9.1 to 5.3.2.
  • Updated trio-typing version from 0.7.0 to 0.10.0.
  • +3/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-py Python Bindings label Apr 19, 2025
    @qodo-merge-pro qodo-merge-pro bot added Review effort 1/5 and removed C-py Python Bindings labels Apr 19, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg cgoldberg merged commit 3d055cd into SeleniumHQ:trunk Apr 19, 2025
    12 checks passed
    @cgoldberg cgoldberg deleted the py-upgrade-mypy-deps branch April 19, 2025 05:02
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants