Skip to content

Log request times for partners API and other HTTP fetch #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 4 commits into from
Dec 23, 2022
Merged

Log request times for partners API and other HTTP fetch #978

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
383ee9e
Log request times for partners API and other HTTP fetch
amcaplan Dec 23, 2022
888c69e
Add performance import (required for Node < 16)
gonzaloriestra Dec 23, 2022
36fa6d1
Add time to debug messages
gonzaloriestra Dec 23, 2022
23b1cc8
Create stupid-games-type.md
gonzaloriestra Dec 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/cli-kit/src/api/partners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {buildHeaders, debugLogRequest, handlingErrors} from './common.js'
import {ScriptServiceProxyQuery} from './graphql/index.js'
import {partners as partnersFqdn} from '../environment/fqdn.js'
import {graphqlClient} from '../http/graphql.js'
import {debug} from '../output.js'
import {Variables, RequestDocument} from 'graphql-request'

export async function request<T>(query: RequestDocument, token: string, variables?: Variables): Promise<T> {
Expand All @@ -12,7 +13,10 @@ export async function request<T>(query: RequestDocument, token: string, variable
const headers = await buildHeaders(token)
debugLogRequest(api, query, variables, headers)
const client = await graphqlClient({headers, url})
const t0 = performance.now()
const response = await client.request<T>(query, variables)
const t1 = performance.now()
debug(`Request to ${url.toString()} completed in ${Math.round(t1 - t0)} ms`)
return response
})
}
Expand Down
3 changes: 3 additions & 0 deletions packages/cli-kit/src/http/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ export async function shopifyFetch(url: RequestInfo, init?: RequestInit): Respon
Sending ${options.method ?? 'GET'} request to URL ${url.toString()} and headers:
${sanitizedHeadersOutput((options?.headers ?? {}) as {[header: string]: string})}
`)
const t0 = performance.now()
const response = await nodeFetch(url, {...init, agent: await httpsAgent()})
const t1 = performance.now()
debug(`Request to ${url.toString()} completed with status ${response.status} in ${Math.round(t1 - t0)} ms`)
return response
}