vscode-spotify extension custom marquee dashboard widget#182
Open
lorenzejay wants to merge 11 commits intoShyykoSerhiy:masterfrom
Open
vscode-spotify extension custom marquee dashboard widget#182lorenzejay wants to merge 11 commits intoShyykoSerhiy:masterfrom
lorenzejay wants to merge 11 commits intoShyykoSerhiy:masterfrom
Conversation
… spotify is installed
…idget Stateful marquee vscode-spotify widget
|
Would make this #170 obsolete? |
Author
Yes, I will close the that original PR. |
|
Is this ready to go? |
Author
Yes. PR is ready to go but has been waiting to be reviewed by the maintainer for quite some time now. We are hoping this gets merged. |
@lorenzejay Can we merge? |
Author
|
I don't think we can directly merge unless you have those project rights. But if you have marquee already installed you can go to the forked branch and install the custom release there to show it on your dash. Otherwise, we are still waiting for this PR to get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leveraging the extension host to create a custom widget that lives on our marquee dashboard as well as upgraded outdated npm packages and cleanup on types. Looking forward to your feedback.