-
-
Notifications
You must be signed in to change notification settings - Fork 397
Add infinite timespans #7956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sovdeeth
wants to merge
2
commits into
SkriptLang:dev/feature
Choose a base branch
from
sovdeeth:feature/forever
base: dev/feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add infinite timespans #7956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Efnilite
approved these changes
Jun 17, 2025
Burbulinis
approved these changes
Jun 17, 2025
Efnilite
requested changes
Jun 17, 2025
Efnilite
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking changes
Pull or feature requests that contain breaking changes (API, syntax, etc.)
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature
Pull request adding a new feature.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Potions have had truly infinite durations for a while now, but using them in Skript has been a bit hit or miss. EffPotionEffect has a separate flag for them, exclusive with the duration timespan option. ExprPotionEffect doesn't even allow it. A simple and elegant solution would be to allow
an infinite duration
as a timespan, or a similar syntax for infinite duration.The upcoming potions rework would also benefit from this concept.
Solution
This PR adds the ability for a timespan to be infinite by using Long.MAX_VALUE milliseconds to represent an eternity:
[an] eternity, forever, [an] (indefinite|infinite) (duration|timespan)
.Math operations on eternities act like Double.POSITIVE_INFINITY, though operations that would result in NaN instead return a 0 length timespan.
Since the backing value for an eternity is MAX_VALUE, it means that any syntax given an infinite timespan that doesn't have explicit infinity support can instead treat it as normal and still get the largest possible value for use.
CondIsInfinite has been updated to accept timespans.
ExprPotionEffect has had an
[a]
added to the start of its patterns for grammatical reasons.Breaking changes:
Testing Completed
LitEternity.sk
Supporting Information
The Temporal interfaces that Timespan and TimePeriod implement don't support infinite values, so it may be wise to deprecate those methods and eventually un-implement the temporals.
Completes: #7458
Related: none