Skip to content

Remove aioredis - not being used #2854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

asherf
Copy link
Collaborator

@asherf asherf commented Jul 1, 2025

It was added here: #285 but I don't see any code actually using it
also it is not actively maintained https://github.com/joanvila/aioredlock/commits/master/

@asherf asherf requested a review from Copilot July 1, 2025 17:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused and unmaintained aioredlock dependency from the project configuration.

  • Deleted aioredlock entry from pyproject.toml.
Comments suppressed due to low confidence (1)

pyproject.toml:53

  • Make sure to update the lockfile (e.g., poetry.lock) after removing this dependency so there are no mismatches between pyproject.toml and the lockfile.
]

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a3d0141 in 1 minute and 12 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. pyproject.toml:52
  • Draft comment:
    PR title says 'Remove aioredis' but the change removes 'aioredlock'. Please confirm if the correct dependency is being removed.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment violates several rules. It's asking for confirmation/verification from the author. It's not pointing out a clear code issue that needs to be fixed. The actual change (removing a dependency) is clear and straightforward. Whether it's aioredis or aioredlock doesn't affect the code quality or functionality - if it was the wrong one, the build would fail. The comment might be catching a genuine mistake in either the PR title or the intended change. This could prevent removing the wrong dependency. Even if there is a mismatch, this is something that would be immediately apparent in testing - if the wrong dependency was removed, the build would fail. We should trust the author to have tested their changes. Delete this comment as it violates the rules against asking for confirmation and commenting on dependency changes that would be caught by the build.

Workflow ID: wflow_O7GLXPsUP2GBZHVT

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

It was added here: Skyvern-AI#285
but I don't see any code actually using it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant