Fix #74 - prevent borrowing 'static from non-'static #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
This bug only affects you if you have a
&'static _
field, such as&'static [u8]
or&'static str
, and you decode from a non-'static
buffer. No other lifetimes are affected.'__de: 'static
bound forimpl Decoder
andimpl Decode
of any item with a&'static _
field, exceptPhantomData<&'static _>
.impl Default
andimpl View
, but I didn't think adding complexity was justified for no change in which user programs compile&'static str
from a'static
bufferPhantomData<&'static str>
from a non-'static
bufferStaticStr
(wheretype StaticStr = &'static str
), even from a'static
bufferDiff for a simple struct with one

'static
field: